Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add details to the readme #23

Merged
merged 2 commits into from
Sep 15, 2021
Merged

chore: add details to the readme #23

merged 2 commits into from
Sep 15, 2021

Conversation

csholmq
Copy link
Contributor

@csholmq csholmq commented Sep 15, 2021

Clarify the steps required in order to set this up.

Clarify the steps required in order to set this up.
@Souvikns
Copy link
Owner

@csholmq firstly thanks for the contribution 🙏🏻
Let me know when you are done, I will merge this.

@csholmq
Copy link
Contributor Author

csholmq commented Sep 15, 2021

I just had one more small commit. But my git credentials didn't work so I need to fix this tonight.

As the release is named `1.0.0` the example in the readme will fail to fetch `v1.0.0`.
@csholmq
Copy link
Contributor Author

csholmq commented Sep 15, 2021

Ready for merge @Souvikns

Copy link
Owner

@Souvikns Souvikns left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀📦

@Souvikns Souvikns merged commit 090f4be into Souvikns:main Sep 15, 2021
@csholmq csholmq deleted the patch-1 branch September 16, 2021 09:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants