-
Notifications
You must be signed in to change notification settings - Fork 641
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improvement on topBar for Macintosh. closes #501 closes #533 #577
Conversation
Looks great @LeGfrey although can we make them a bit smaller? instead 10px let's try arround 7px |
Yeah they should be a bit smaller to be consistent with the OS, but looks awesome, @LeGfrey :) |
There should be also a slightly darker border around the circle (button) I believe. *I think the colors still don't completely match the original buttons, how did you get the colors @LeGfrey? What about: |
Smaller, but no dark border please, because it would make everything blurry. In the screenshot it is also not with a dark border. |
Well, the first screenshot where is a light background there is definitely something around the circle. Good thing is that |
No I don't think that it is needed. Should be ok to go without a border. But lets just wait for @weblancaster |
What @LeGfrey did is good enough for now.. we just need to get a bit smaller from 10px to 7px maybe. no border. |
Thank you guys for your feedback 😄 Please tell me if it's still too large or if you prefer a border or a different color. Concerning colors @Mattijah, I used an eye dropper on a screenshot from apple documentation. Anyway, I'll be glad to contribute to such a project 😃 |
They need to go up a little now.. And 1-2px more close to each other
|
And perhaps update the screenshot on the readme |
Hi guys :)
For my first contrib I decided to improve a bit the top toolbar for macintosh (my current OS).
To answer these issues #501 and #533 I mainly changed the close / mini / maxmimize buttons to be smaller and more colorful. And changed a bit the Y position of elements (search bar and buttons).
Here's some screenshots of the differences.
Before :
After :