-
Notifications
You must be signed in to change notification settings - Fork 641
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature: Makefile and debian packaging for linux64 #507
Feature: Makefile and debian packaging for linux64 #507
Conversation
@JonasGroeger this is awesome, I will test it on Ubuntu tonight 😸 |
@jakejarrett you are the man.. haha thanks for testing this I will trust your judgment on this and merge once you give green light |
It fails on the last step due to a missing secret key, I'm not sure if this is an error on my part (I'll be able to test more during the weekend)
|
@jakejarrett This is the signing part. The key
You can create a keypair (public, private) using
and then following the steps. Using
you can then get your key id. |
Ah @JonasGroeger got it! Awesome, build works perfectly just need a .desktop file for the app to be show in launchers 😸 but that be in a separate pr if necessary |
So are we good to merge @jakejarrett ? anything we will need to add to README.md or documentation? |
This is all good, we should document the build process for building .deb package, but for now it should be fine to merge |
@JonasGroeger can you document the build process for .deb package? |
Thanks for testing this @jakejarrett |
Feature: Makefile and debian packaging for linux64
This is now released. |
Great thanks @JonasGroeger |
@JonasGroeger I was retesting this on ubuntu and it appears They're not building correctly on my end. Its installed to the right directory and such, but when i try to run it will just show the default nwjs page instead of Soundnode. Lintian returns an error saying the sources are missing. |
@jakejarrett Can you give me the output of the whole script? The lintian errors are usually normal and nothing big to worry about. |
Here's the full build log, its fairly long so i put it in a gist |
Are you sure you posted the whole thing? I expected a signing process after lintian. Ah, I see. You didn't provide a key. Thats fine. If the run was successful, which is the case, you should have a To test the output, you can run There, you can see if all nessecary files are present. If they are, there is obviously something wrong with soundnode. The Makefile essentially does just |
@JonasGroeger Comparing the source & installed, there's definitely a difference. The one in /opt/ is ~4MB smaller. I'll spend some time with it and see whats going on |
Hello!
I added a Makefile and a way to create a debian package out of this software. To create the debian package, run
debuild
in the project root. This will create a*.deb
, likesoundnodeapp_0.6.1-1_amd64.deb
in the parent directory..
.To sign the build with your custom key, not the maintainers one (mine), you need to pass the parameter
-k
to debuild, like this:For example
Pull request to 'master', since 'dev' didn't exist