forked from smplman/qmk_firmware
-
Notifications
You must be signed in to change notification settings - Fork 417
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Workaround SN32 USB code deficiencies for remote wakeup to work #28
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stdvar
force-pushed
the
sn32_remote_wakeup
branch
2 times, most recently
from
April 19, 2021 02:38
26ed040
to
ca45f05
Compare
stdvar
force-pushed
the
sn32_remote_wakeup
branch
from
April 19, 2021 04:36
ca45f05
to
bbcfa47
Compare
updated directly on sn32 branch |
stdvar
pushed a commit
to SonixQMK/ChibiOS-Contrib
that referenced
this pull request
Oct 11, 2021
stdvar
pushed a commit
that referenced
this pull request
Oct 11, 2021
14 tasks
dexter93
pushed a commit
that referenced
this pull request
Oct 12, 2021
for history see: #28 qmk#12870 SonixQMK/ChibiOS-Contrib#24 Co-authored-by: stdvar <stdvar@xyz.com>
HorrorTroll
pushed a commit
to HorrorTroll/qmk_firmware
that referenced
this pull request
Nov 4, 2021
…K#123) for history see: SonixQMK#28 qmk#12870 SonixQMK/ChibiOS-Contrib#24 Co-authored-by: stdvar <stdvar@xyz.com>
dexter93
pushed a commit
to SonixQMK/ChibiOS-Contrib
that referenced
this pull request
Nov 21, 2021
dexter93
pushed a commit
to dexter93/ChibiOS-Contrib
that referenced
this pull request
Jan 4, 2022
dexter93
pushed a commit
to SonixQMK/ChibiOS-Contrib
that referenced
this pull request
Feb 12, 2022
HorrorTroll
pushed a commit
to HorrorTroll/qmk_firmware
that referenced
this pull request
Nov 22, 2022
add `process_record_user` call into `process_record_kb`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
prevent usb driver restart after remote wakeup has been triggered.
Chibios-contrib got remote wakeup updates in SN32 USB driver.
Current handling of wakeup event in qmk restarts USB driver (see pr: qmk#10088)
USB driver restart and enumeration is unnecessary in general however SN32 USB code doesn't handle driver restart properly.
Following need to be done to handle usb driver restart:
While USB driver is restarted in qmk all EP configuration is destroyed (which will be initialized again after enumeration).
To shortcut deficiencies of SN32 USB code and avoid unnecessary reenumeration at each wakeup this PR disables usb driver restart at remote wakeup.
Types of Changes
Issues Fixed or Closed by This PR
added remote wakeup handling
Checklist