Time to merge #339
Merged
Time to merge #339
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…y SQLite specific code
For mp3 files, the "Part Of a Set" tag (`TPOS`) can be either a single number, or two numbers separated by a '/' [1]. Sonerezh always wanted two numbers separated by a '/', and, for ogg files, only filled the disc tag if both DISCNUMBER and DISCTOTAL existed. This fix does two things: 1. For ogg files, DISCTOTAL is now optional 2. Handle both formats, i.e. w/ and w/o '/' [1] http://id3.org/id3v2.3.0
Detect DISCNUMBER tag without DISCTOTAL
Adding a translation file for German Translation of the web interface Add German locale Fix indetation Fix typo Fix indent Applying 4 space coding convention to indentation Fixes some extra whitespace and some typos Fixing the rest of extra whitespace
Adding German Translation
This was referenced Aug 13, 2018
This was referenced Aug 17, 2018
Closed
|
Thank you thank you thank you! |
|
You're welcome :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's time to backport the work from the main fork.