Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Buffer songs preemtively to avoid waiting on song change #114

Closed
wants to merge 1 commit into from
Closed

Buffer songs preemtively to avoid waiting on song change #114

wants to merge 1 commit into from

Conversation

DavidVentura
Copy link

I should've done something to pre-calculate the next random song to be able to buffer it

@MightyCreak
Copy link
Contributor

I'd really like to see that in the next release!

@atomiix
Copy link
Member

atomiix commented Jul 3, 2016

Hi,

I forgot to had a reference to this PR when I anwered #179 but here is what I said :

I was looking for merge your PR but it seems that creating another audio element and loading the next song is not enough, the main audio element will reload the next song anyway.
In addition, it's hard to see because when using a local environment it loads songs very fast.
But in chrome, you can throttle the bandwidth speed in the developer console.

I'm still looking for a good solution to preload the next song, if you have any idea, let me know 😉

@DavidVentura
Copy link
Author

On Firefox I get a 200 on first access, but when the real player requests the file I get a 302 and its instant.

On July 3, 2016 1:52:05 PM GMT-03:00, atomiix notifications@github.com wrote:

Hi,

I forgot to had a reference to this PR when I anwered #179 but here is
what I said :

I was looking for merge your PR but it seems that creating another
audio element and loading the next song is not enough, the main audio
element will reload the next song anyway.
In addition, it's hard to see because when using a local environment
it loads songs very fast.
But in chrome, you can throttle the bandwidth speed in the developer
console.

I'm still looking for a good solution to preload the next song, if
you have any idea, let me know 😉


You are receiving this because you authored the thread.
Reply to this email directly or view it on GitHub:
#114 (comment)

Sent from my Android device with K-9 Mail. Please excuse my brevity.

@lGuillaume124
Copy link
Contributor

Hi,
Thanks for your work, could you rebase your branch on development please?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants