Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SQCPPGHA-9 Rebrand and forward to sonarqube-scan-action/deprecated-c-cpp-action #21

Merged
merged 4 commits into from
Dec 17, 2024

Conversation

antonioaversa
Copy link
Contributor

@antonioaversa antonioaversa commented Dec 11, 2024

SQCPPGHA-9

Caution

Don't forget to update the forward from antonio/SQCPPGHA-9-rebranding-and-forward to v4.2.0, once sonarqube-scan-action@v4.2.0 is released.

Done

Related PR on sonarqube-scan-action side: SonarSource/sonarqube-scan-action#161

Content of this PR:

  • Rebranding, as done for sonarcloud-github-c-cpp
  • Forwards the execution of the action to sonarqube-scan-action/deprecate-c-cpp.
  • Remove sonar-scanner-version: not needed anymore, added on sonarqube-scan-action side by this PR
  • Remove the version_update.yml workflow to update sonar-scanner-version: not needed anymore, added on sonarqube-scan-action side by [this PR]
  • Remove QA tests related to scripts: not needed anymore, added on sonarqube-scan-action side by [this PR]

With this forward:

  • we solve the double maintenance issue problem between sonarqube-scan-action and sonarqube-github-c-cpp
  • we will not have to change the shape of sonarqube-scan-action, nor expose any sub-action except for sonarqube-scan-action/install-build-wrapper
  • sonarqube-scan-action/install-build-wrapper and sonarqube-scan-action/deprecate-c-cpp can share scripts.

Successful runs:

Reruns after releasing v4.2.1:

@antonioaversa antonioaversa force-pushed the antonio/SQCPPGHA-9-rebranding-and-forward branch from ac82e3f to 2d65740 Compare December 11, 2024 12:50
@antonioaversa antonioaversa force-pushed the antonio/SQCPPGHA-9-rebranding-and-forward branch from 2d65740 to b9a2e35 Compare December 11, 2024 13:20
@antonioaversa antonioaversa changed the title SQCPPGHA-9 Rebranding and forwarding to sonarqube-scan-action/deprecated-c-cpp-action SQCPPGHA-9 Rebrand and forward to sonarqube-scan-action/deprecated-c-cpp-action Dec 11, 2024
action.yml Outdated Show resolved Hide resolved
@antonioaversa antonioaversa marked this pull request as draft December 11, 2024 13:55
@antonioaversa antonioaversa force-pushed the antonio/SQCPPGHA-9-rebranding-and-forward branch from b9a2e35 to bf20180 Compare December 11, 2024 16:37
@antonioaversa antonioaversa requested a review from a team December 11, 2024 18:23
@antonioaversa antonioaversa marked this pull request as ready for review December 11, 2024 18:24
Copy link
Member

@henryju henryju left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

README.md Outdated Show resolved Hide resolved
action.yml Outdated Show resolved Hide resolved
antonioaversa and others added 3 commits December 12, 2024 12:22
@antonioaversa antonioaversa force-pushed the antonio/SQCPPGHA-9-rebranding-and-forward branch from 18e2b96 to e91b8e5 Compare December 17, 2024 11:01
@antonioaversa antonioaversa merged commit f415b51 into master Dec 17, 2024
8 checks passed
@antonioaversa antonioaversa deleted the antonio/SQCPPGHA-9-rebranding-and-forward branch December 17, 2024 11:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants