Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SLVSCODE-966 improve UX with taint vulnerabilities on file change #671

Merged
merged 2 commits into from
Jan 6, 2025
Merged

SLVSCODE-966 improve UX with taint vulnerabilities on file change #671

merged 2 commits into from
Jan 6, 2025
+51 −6

Conversation

sophio-japharidze-sonarsource
Copy link
Contributor

@sophio-japharidze-sonarsource sophio-japharidze-sonarsource commented Dec 27, 2024 •
edited by jira bot
Loading

Before
before

After
after

SLVSCODE-966

@sophio-japharidze-sonarsource sophio-japharidze-sonarsource force-pushed the SLVSCODE-966_better_taint_ux_file_change branch from 620189d to 4d54788 Compare December 27, 2024 14:32
@sophio-japharidze-sonarsource sophio-japharidze-sonarsource marked this pull request as ready for review January 2, 2025 11:20
jblievremont
jblievremont requested changes Jan 6, 2025
View reviewed changes
Copy link
Member

@jblievremont jblievremont left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Almost there!

src/extension.ts Outdated Show resolved Hide resolved
src/extension.ts Outdated Show resolved Hide resolved
@sophio-japharidze-sonarsource sophio-japharidze-sonarsource force-pushed the SLVSCODE-966_better_taint_ux_file_change branch from e8878d0 to 5f8d265 Compare January 6, 2025 12:40
@sonarqube-next SonarQube-Next
Copy link

sonarqube-next bot commented Jan 6, 2025

Quality Gate passed Quality Gate passed

Issues
0 New issues
0 Fixed issues
0 Accepted issues

Measures
0 Security Hotspots
31.3% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube

jblievremont
jblievremont approved these changes Jan 6, 2025
View reviewed changes
Copy link
Member

@jblievremont jblievremont left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@sophio-japharidze-sonarsource sophio-japharidze-sonarsource merged commit 8590217 into master Jan 6, 2025
12 checks passed
@sophio-japharidze-sonarsource sophio-japharidze-sonarsource deleted the SLVSCODE-966_better_taint_ux_file_change branch January 6, 2025 14:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jblievremont jblievremont jblievremont approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sophio-japharidze-sonarsource @jblievremont