-
Notifications
You must be signed in to change notification settings - Fork 81
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SLVSCODE-984 adjust wording about free editions #667
SLVSCODE-984 adjust wording about free editions #667
Conversation
1cf989c
to
d10c5e7
Compare
@@ -24,7 +24,7 @@ export function languageServerCommand( | |||
|
|||
const params = []; | |||
if (DEBUG) { | |||
params.push('-agentlib:jdwp=transport=dt_socket,server=y,suspend=n,address=8001,quiet=y'); | |||
params.push('-agentlib:jdwp=transport=dt_socket,server=y,suspend=n,address=8000,quiet=y'); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why change the port?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I accidentally changed the port to 8001 in a previous commit. This is just to revert the change
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's a change not related to the ticket. Can you please put it as a separate commit into this PR and don't squash them on merge? So history would be clear.
d10c5e7
to
132b4c6
Compare
Quality Gate passedIssues Measures |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
SLVSCODE-984