Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SLVSCODE-984 adjust wording about free editions #667

Merged
merged 3 commits into from
Dec 24, 2024

Conversation

sophio-japharidze-sonarsource
Copy link
Contributor

@sophio-japharidze-sonarsource sophio-japharidze-sonarsource commented Dec 23, 2024

@sophio-japharidze-sonarsource sophio-japharidze-sonarsource force-pushed the SLVSCODE-984_promote_free_SQC branch 2 times, most recently from 1cf989c to d10c5e7 Compare December 24, 2024 09:06
@@ -24,7 +24,7 @@ export function languageServerCommand(

const params = [];
if (DEBUG) {
params.push('-agentlib:jdwp=transport=dt_socket,server=y,suspend=n,address=8001,quiet=y');
params.push('-agentlib:jdwp=transport=dt_socket,server=y,suspend=n,address=8000,quiet=y');
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why change the port?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I accidentally changed the port to 8001 in a previous commit. This is just to revert the change

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's a change not related to the ticket. Can you please put it as a separate commit into this PR and don't squash them on merge? So history would be clear.

Copy link
Contributor

@kirill-knize-sonarsource kirill-knize-sonarsource left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sophio-japharidze-sonarsource sophio-japharidze-sonarsource merged commit 23161a4 into master Dec 24, 2024
11 checks passed
@sophio-japharidze-sonarsource sophio-japharidze-sonarsource deleted the SLVSCODE-984_promote_free_SQC branch December 24, 2024 10:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants