Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SLVSCODE-953 untar eslint-bridge bundle and send its path to slls #659

Closed
wants to merge 2 commits into from
Closed

SLVSCODE-953 untar eslint-bridge bundle and send its path to slls #659

wants to merge 2 commits into from

Conversation

sophio-japharidze-sonarsource
Copy link
Contributor

No description provided.

@sophio-japharidze-sonarsource sophio-japharidze-sonarsource marked this pull request as draft December 6, 2024 14:49
@sophio-japharidze-sonarsource sophio-japharidze-sonarsource force-pushed the SLVSCODE-953_fixed_eslint_bridge_server_path branch from 1944bb9 to 0ebec6b Compare December 9, 2024 12:21
@sophio-japharidze-sonarsource sophio-japharidze-sonarsource force-pushed the SLVSCODE-953_fixed_eslint_bridge_server_path branch from 0ebec6b to 856cad9 Compare December 9, 2024 12:40
@sophio-japharidze-sonarsource sophio-japharidze-sonarsource marked this pull request as ready for review December 9, 2024 14:38
jblievremont
jblievremont requested changes Dec 9, 2024
View reviewed changes
Copy link
Member

@jblievremont jblievremont left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good on the functional side (and tested manually); let's make sure that we are not sending anything unnecessary in the telemetry payload 😅

src/extension.ts Outdated Show resolved Hide resolved
@sonarqube-next SonarQube-Next
Copy link

Quality Gate passed Quality Gate passed

Issues
0 New issues
0 Fixed issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarQube

jblievremont
jblievremont approved these changes Dec 10, 2024
View reviewed changes
Copy link
Member

@jblievremont jblievremont left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM ⏩!

@sophio-japharidze-sonarsource
Copy link
Contributor Author

Superseded by #661

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jblievremont jblievremont jblievremont approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sophio-japharidze-sonarsource @jblievremont