Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SLVSCODE-956 list files in folder race condition #657

Conversation

sophio-japharidze-sonarsource
Copy link
Contributor

@sophio-japharidze-sonarsource sophio-japharidze-sonarsource commented Dec 5, 2024

Copy link
Member

@jblievremont jblievremont left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good on the functional side, see my small comment 🙈

src/fileSystem/fileSystemServiceImpl.ts Outdated Show resolved Hide resolved
@sophio-japharidze-sonarsource sophio-japharidze-sonarsource force-pushed the SLVSCODE-956_listFilesInFolder_race_condition branch from 171a51c to 8296105 Compare December 5, 2024 14:06
@sophio-japharidze-sonarsource sophio-japharidze-sonarsource merged commit cc70a9e into master Dec 5, 2024
11 checks passed
@sophio-japharidze-sonarsource sophio-japharidze-sonarsource deleted the SLVSCODE-956_listFilesInFolder_race_condition branch December 5, 2024 14:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants