Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SLVSCODE-891 new icons for standard severity mode #646

Merged
merged 3 commits into from
Nov 25, 2024
Merged

SLVSCODE-891 new icons for standard severity mode #646

merged 3 commits into from
Nov 25, 2024

Conversation

sophio-japharidze-sonarsource
Copy link
Contributor

@sophio-japharidze-sonarsource sophio-japharidze-sonarsource commented Nov 20, 2024 •
edited by jira bot
Loading

jblievremont
jblievremont reviewed Nov 22, 2024
View reviewed changes
Copy link
Member

@jblievremont jblievremont left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good for a first baby step 🙂

It would be even better if we could de-duplicate the type icons; I'm not comfortable with having 15 icons only because of different colors.

images/severity/blocker.svg Outdated Show resolved Hide resolved
src/rules/rulepanel.ts Outdated Show resolved Hide resolved
@sonarqube-next SonarQube-Next
Copy link

Quality Gate passed Quality Gate passed

Issues
0 New issues
0 Fixed issues
0 Accepted issues

Measures
0 Security Hotspots
16.7% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube

jblievremont
jblievremont approved these changes Nov 25, 2024
View reviewed changes
Copy link
Member

@jblievremont jblievremont left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice 🤩 and works very well with theme switching 💯

@sophio-japharidze-sonarsource sophio-japharidze-sonarsource merged commit 60557c2 into master Nov 25, 2024
11 checks passed
@sophio-japharidze-sonarsource sophio-japharidze-sonarsource deleted the SLVSCODE-891_new_standard_mode_icons branch November 25, 2024 14:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jblievremont jblievremont jblievremont approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sophio-japharidze-sonarsource @jblievremont