Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SCANNPM-58 Avoid conflicts between axios's proxy option and custom http(s) agents #179

Merged
merged 1 commit into from
Nov 28, 2024

Conversation

7PH
Copy link

@7PH 7PH commented Nov 26, 2024

Fixes SCANNPM-58 reported by this user.

I chose to set proxy: false the closest to where we set the HTTP[S] agents in the code

Copy link

@lucas-paulger-sonarsource lucas-paulger-sonarsource left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

validated the fix 🎉 good to go

@7PH 7PH merged commit 1387c91 into master Nov 28, 2024
9 checks passed
@7PH 7PH deleted the bugfix/br/scannpm-58-fix-axios-proxy branch November 28, 2024 08:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants