Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SCANNPM-56 Remove deprecated CIRRUS_AWS_SUBNET #176

Merged
merged 3 commits into from
Nov 19, 2024
Merged

SCANNPM-56 Remove deprecated CIRRUS_AWS_SUBNET #176

merged 3 commits into from
Nov 19, 2024

Conversation

saberduck
Copy link

@saberduck saberduck commented Nov 6, 2024 •
edited by jira bot
Loading

@hashicorp-vault-sonar-prod hashicorp-vault-sonar-prod bot changed the title Remove deprecated CIRRUS_AWS_SUBNET SCANNPM-56 Remove deprecated CIRRUS_AWS_SUBNET Nov 6, 2024
yassin-kammoun-sonarsource
yassin-kammoun-sonarsource approved these changes Nov 6, 2024
View reviewed changes
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The Windows QA job failed.

@vdiez
Copy link

vdiez commented Nov 6, 2024

I may be wrong, but I think you need to migrate to v3 to remove those fields. I think you need to change first line of cirrus.star to

load("github.com/SonarSource/cirrus-modules@v3", "load_features")

@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@saberduck saberduck merged commit 5501a35 into master Nov 19, 2024
6 checks passed
@saberduck saberduck deleted the fix_build branch November 19, 2024 09:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yassin-kammoun-sonarsource yassin-kammoun-sonarsource yassin-kammoun-sonarsource approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@saberduck @vdiez @yassin-kammoun-sonarsource