-
Notifications
You must be signed in to change notification settings - Fork 231
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reproducer for #8988 S1172 FP: Don't report on partial method parameters #8989
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
martin-strecker-sonarsource
requested a review
from cristian-ambrosini-sonarsource
March 27, 2024 14:53
github-actions
bot
assigned cristian-ambrosini-sonarsource and unassigned martin-strecker-sonarsource
Mar 27, 2024
analyzers/tests/SonarAnalyzer.Test/TestCases/MethodParameterUnused.CSharp11.cs
Outdated
Show resolved
Hide resolved
cristian-ambrosini-sonarsource
suggested changes
Mar 27, 2024
analyzers/tests/SonarAnalyzer.Test/Rules/MethodParameterUnusedTest.cs
Outdated
Show resolved
Hide resolved
analyzers/tests/SonarAnalyzer.Test/TestCases/MethodParameterUnused.RoslynCfg.cs
Outdated
Show resolved
Hide resolved
github-actions
bot
assigned martin-strecker-sonarsource and unassigned cristian-ambrosini-sonarsource
Mar 27, 2024
Quality Gate passedIssues Measures |
Quality Gate passedIssues Measures |
cristian-ambrosini-sonarsource
approved these changes
Mar 28, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
github-actions
bot
assigned martin-strecker-sonarsource and unassigned martin-strecker-sonarsource
Mar 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reproducer for #8988