Delete S2228 #8058
Merged
Delete S2228 #8058
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
assigned csaba-sagi-sonarsource and unassigned mary-georgiou-sonarsource
analyzers/tests/SonarAnalyzer.UnitTest/Rules/DoNotWriteToStandardOutputTest.cs
Outdated
Show resolved
Hide resolved
analyzers/tests/SonarAnalyzer.UnitTest/TestCases/ConsoleLogging.cs
Outdated
Show resolved
Hide resolved
github-actions
bot
assigned csaba-sagi-sonarsource and unassigned csaba-sagi-sonarsource
csaba-sagi-sonarsource
approved these changes
Sep 26, 2023
There was a problem hiding this comment.
I will approve, please fix the code smell before merging it and also please rename the classes in DoNotWriteToStandardOutput_Conditionals1 and 2 to something else as S2228 was removed so it should not be mentioned.
github-actions
bot
assigned mary-georgiou-sonarsource and unassigned csaba-sagi-sonarsource
|
Kudos, SonarCloud Quality Gate passed!
|
|
Kudos, SonarCloud Quality Gate passed! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rspec PR: SonarSource/rspec#3130
=========================
Deleting S2228 as it has been deprecated.
Deprecated since:
sonar-dotnet 8.15.0.24505.
SQ 8.6.0.39681