Fix S2583/S2589 FP: Do not raise when condition is in the body of a lock statement. #7789
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@Tim-Pohlmann this is draft until peach is back up and I can see more examples for potential UTs. |
mary-georgiou-sonarsource
force-pushed
the
mary/ignore-locksstatements
branch
3 times, most recently
from
e454226 to
5f7493a
Compare
mary-georgiou-sonarsource
force-pushed
the
mary/ignore-locksstatements
branch
from
2dbf8a3 to
1ba696f
Compare
Tim-Pohlmann
approved these changes
Aug 15, 2023
| @@ -18,6 +18,7 @@ | |||
| * Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301, USA. | |||
| */ | |||
|
|
|||
| using Microsoft.CodeAnalysis.CSharp; | |||
There was a problem hiding this comment.
Suggested change
| using Microsoft.CodeAnalysis.CSharp; |
| @@ -392,15 +392,15 @@ void Method() | |||
| continue; | |||
| } | |||
|
|
|||
| if (sb is null) // Noncompliant | |||
| if (sb is null) // Noncompliant FP | |||
|
Kudos, SonarCloud Quality Gate passed!
|
|
Kudos, SonarCloud Quality Gate passed! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In a multithreading context, it makes sense to check conditions twice (before and after the lock).
That's why we are ignoring what is in the lock statement body to not create a lot of noise with false positive issues.
Related to #3353