Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix S2930 FN #6685

Merged
merged 3 commits into from
Jan 30, 2023
Merged

Fix S2930 FN #6685

merged 3 commits into from
Jan 30, 2023

Conversation

zsolt-kolbay-sonarsource
Copy link
Contributor

Fixes #5879

@zsolt-kolbay-sonarsource zsolt-kolbay-sonarsource changed the title S2930 FP: Fix search for using declarations S2930: FP, Fix search for using declarations Jan 27, 2023
@pavel-mikula-sonarsource pavel-mikula-sonarsource changed the title S2930: FP, Fix search for using declarations Fix S2930 FP: Recognize IAsyncDisposable Jan 30, 2023
@sonarcloud
Copy link

sonarcloud bot commented Jan 30, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@sonarcloud
Copy link

sonarcloud bot commented Jan 30, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

100.0% 100.0% Coverage
0.0% 0.0% Duplication

@zsolt-kolbay-sonarsource zsolt-kolbay-sonarsource changed the title Fix S2930 FP: Recognize IAsyncDisposable Fix S2930 FN Jan 30, 2023
andrei-epure-sonarsource
andrei-epure-sonarsource approved these changes Jan 30, 2023
View reviewed changes
Copy link
Contributor

@andrei-epure-sonarsource andrei-epure-sonarsource left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@andrei-epure-sonarsource andrei-epure-sonarsource merged commit f8aff1b into master Jan 30, 2023
@andrei-epure-sonarsource andrei-epure-sonarsource deleted the Zsolt/S2930-FP-IAsyncDisposable-Fix branch January 30, 2023 11:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andrei-epure-sonarsource andrei-epure-sonarsource andrei-epure-sonarsource approved these changes

Assignees

@zsolt-kolbay-sonarsource zsolt-kolbay-sonarsource

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Fix S2930 FP: Recognize IAsyncDisposable
2 participants
@zsolt-kolbay-sonarsource @andrei-epure-sonarsource