Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create rule S6958: Literals should not be used as functions #3812

Merged
merged 8 commits into from
Mar 27, 2024

Conversation

github-actions[bot]
Copy link
Contributor

You can preview this rule here (updated a few minutes after each push).

Review

A dedicated reviewer checked the rule description successfully for:

  • logical errors and incorrect information
  • information gaps and missing content
  • text style and tone
  • PR summary and labels follow the guidelines

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left minor suggestions, otherwise looks good to me!

rules/S6958/javascript/rule.adoc Outdated Show resolved Hide resolved
rules/S6958/javascript/rule.adoc Outdated Show resolved Hide resolved
rules/S6958/metadata.json Outdated Show resolved Hide resolved
rules/S6958/javascript/rule.adoc Outdated Show resolved Hide resolved
@yassin-kammoun-sonarsource yassin-kammoun-sonarsource changed the title Create rule S6958 Create rule S6958: Literals should not be used as functions Mar 26, 2024
@yassin-kammoun-sonarsource yassin-kammoun-sonarsource marked this pull request as ready for review March 26, 2024 10:00
Co-authored-by: Yassin Kammoun <52890329+yassin-kammoun-sonarsource@users.noreply.github.com>
Co-authored-by: Yassin Kammoun <52890329+yassin-kammoun-sonarsource@users.noreply.github.com>
Co-authored-by: Yassin Kammoun <52890329+yassin-kammoun-sonarsource@users.noreply.github.com>
Co-authored-by: Yassin Kammoun <52890329+yassin-kammoun-sonarsource@users.noreply.github.com>
Copy link

Quality Gate passed Quality Gate passed for 'rspec-tools'

Issues
0 New issues
0 Fixed issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarQube

Copy link

Quality Gate passed Quality Gate passed for 'rspec-frontend'

Issues
0 New issues
0 Fixed issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarQube

@ilia-kebets-sonarsource ilia-kebets-sonarsource merged commit 1df4ed5 into master Mar 27, 2024
10 of 11 checks passed
@ilia-kebets-sonarsource ilia-kebets-sonarsource deleted the rule/add-RSPEC-S6958 branch March 27, 2024 14:38
@ericmorand-sonarsource ericmorand-sonarsource removed their assignment Apr 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants