Create rule S6575: Use TimeZoneInfo.FindSystemTimeZoneById instead of TimezoneConverter #1729
Conversation
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
mary-georgiou-sonarsource
changed the title
mary-georgiou-sonarsource
force-pushed
the
rule/add-RSPEC-S6575
branch
3 times, most recently
from
76a73b8 to
cd0bb60
Compare
mary-georgiou-sonarsource
requested review from
cristian-ambrosini-sonarsource and
cynthiabethea
mary-georgiou-sonarsource
force-pushed
the
rule/add-RSPEC-S6575
branch
from
b072c69 to
820f1a8
Compare
rules/S6575/how.adoc
Outdated
| @@ -0,0 +1,4 @@ | |||
| == How to fix it | |||
|
|
|||
| There's no need to translate manually between time zones; it is enough `TimeZoneInfo.FindSystemTimeZoneById(string timezone)`, where the timezone can be IANA or Windows format. | |||
There was a problem hiding this comment.
| There's no need to translate manually between time zones; it is enough `TimeZoneInfo.FindSystemTimeZoneById(string timezone)`, where the timezone can be IANA or Windows format. | |
| There's no need to translate manually between time zones; it is enough to call `TimeZoneInfo.FindSystemTimeZoneById(string timezone)`, where the timezone can be IANA or Windows format. |
There was a problem hiding this comment.
The "to call" should go before the method name, no?
rules/S6575/why-dotnet.adoc
Outdated
| == Why is this an issue? | ||
|
|
||
| The method `TimeZoneInfo.FindSystemTimeZoneById(string timezone)` can get both IANA and Windows timezones as input and automatically convert one to the other if the requested time zone is not found on the system. | ||
| This means that one does not have to handle the conversion and make the code more complicated and thus more difficult to maintain. |
There was a problem hiding this comment.
I'd change this to: "Because one does not need to handle the conversion the code will be less complex and easier to maintain."
|
SonarQube Quality Gate for 'rspec-frontend'
|
|
SonarQube Quality Gate for 'rspec-tools'
|
christophe-zurn-sonarsource
force-pushed
the
rule/add-RSPEC-S6575
branch
from
8918c85 to
b2b202f
Compare
|
SonarQube Quality Gate for 'rspec-tools'
|
|
SonarQube Quality Gate for 'rspec-frontend'
|
|
SonarQube Quality Gate for 'rspec-tools'
|
|
SonarQube Quality Gate for 'rspec-frontend'
|
csaba-sagi-sonarsource
force-pushed
the
rule/add-RSPEC-S6575
branch
from
c9cbeb3 to
24cfdba
Compare
|
SonarQube Quality Gate for 'rspec-tools'
|
|
SonarQube Quality Gate for 'rspec-frontend'
|
You can preview this rule here (updated a few minutes after each push).
This rule should raise when the project targets .net6 and TimeZoneConverter methods for IANA and Windows Timezones are used.
IanaToWindowsWindowsToIanaTryIanaToWindowsTryWindowsToIanaTimeZoneConverter also covers Rails Timezones - we should not raise there as imeZoneInfo.FindSystemTimeZoneById does not cover these.