Skip to content
This repository has been archived by the owner on Oct 3, 2024. It is now read-only.

Move from a compile-all to a compile-entry-point pattern #463

Merged
merged 1 commit into from
Apr 29, 2024
Merged

Move from a compile-all to a compile-entry-point pattern #463

merged 1 commit into from
Apr 29, 2024

Conversation

ericmorand-sonarsource
Copy link
Contributor

@ericmorand-sonarsource ericmorand-sonarsource commented Apr 26, 2024 •
edited
Loading

Fixes ESLINTJS-43

ericmorand-sonarsource
ericmorand-sonarsource commented Apr 26, 2024
View reviewed changes
package.json
@@ -23,7 +23,7 @@
"LICENSE"
],
"scripts": {
"build": "rimraf lib && tsc -d -p tsconfig.json",
"build": "rimraf lib && tsc -d -p src",
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since I added a tsconfig.json file under src, I target the src project here. Later on, would we want to build the test suite, we can add a tsconfig.json under tests and target the tests project to build the test suite. This way, entry point can be different between the main and the tests projects.

ericmorand-sonarsource
ericmorand-sonarsource commented Apr 26, 2024
View reviewed changes
src/index.ts

const plugin = {
configs: {},
rules: {},
};

const recommendedLegacyConfig: TSESLint.Linter.Config = { plugins: ['sonarjs'], rules: {} };
const recommendedLegacyConfig: TSESLint.Linter.ConfigType = { plugins: ['sonarjs'], rules: {} };
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TSESLint.Linter.Configbeing deprecated, I replaced it with the legit type.

ericmorand-sonarsource
ericmorand-sonarsource commented Apr 26, 2024
View reviewed changes
tests/index.test.ts
@@ -45,7 +45,7 @@ it('should document all rules', () => {
existingRules.forEach(rule => {
expect(README.includes(rule)).toBe(true);
expect(fs.existsSync(`${root}/docs/rules/${rule}.md`)).toBe(true);
expect(rules[rule].meta.docs.url).toBe(
expect(rules[rule].meta.docs!.url).toBe(
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Now that the exported rules is typed, I had to honor the fact that docs can be undefined.

ericmorand-sonarsource
ericmorand-sonarsource commented Apr 26, 2024
View reviewed changes
tsconfig.json
@@ -12,6 +12,5 @@
"outDir": "lib",
"sourceMap": true,
"moduleResolution": "nodenext"
},
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is no need to declare the included files since we now rely on an entry point declared on each project (aka tsconfig.json).

@ericmorand-sonarsource ericmorand-sonarsource force-pushed the compilation-entry-point branch 4 times, most recently from ab7bc61 to 1b8f2da Compare April 26, 2024 10:49
ericmorand-sonarsource
ericmorand-sonarsource commented Apr 26, 2024
View reviewed changes
src/index.ts
});
for (const key in rules) {
const rule = rules[key];
const recommended = rule.meta.docs?.recommended;
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think that, in this case, not destructuring is more readable than destructuring. Feel free to request a change if you think the destructured syntax of the original code is clearer:

const {
    meta: {
      docs: { recommended },
    },
  } = rule;

@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
100.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

zglicz
zglicz approved these changes Apr 26, 2024
View reviewed changes
Copy link
Contributor

@zglicz zglicz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, this is much, much cleaner. Thanks for this!

successkid

@ericmorand-sonarsource ericmorand-sonarsource merged commit a4390e9 into SonarSource:master Apr 29, 2024
1 of 5 checks passed
@ericmorand-sonarsource ericmorand-sonarsource deleted the compilation-entry-point branch April 29, 2024 10:37
@zglicz zglicz added this to the 1.0.0 milestone May 3, 2024
renovate bot referenced this pull request in ScaleLeap/amazon-marketplaces May 8, 2024
@renovate
chore(deps): update dependency eslint-plugin-sonarjs to v1 (#627)
ad670c0 
[![Mend
Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com)

This PR contains the following updates:

| Package | Change | Age | Adoption | Passing | Confidence |
|---|---|---|---|---|---|
|
[eslint-plugin-sonarjs](https://togithub.com/SonarSource/eslint-plugin-sonarjs)
| [`0.25.1` ->
`1.0.3`](https://renovatebot.com/diffs/npm/eslint-plugin-sonarjs/0.25.1/1.0.3)
|
[![age](https://developer.mend.io/api/mc/badges/age/npm/eslint-plugin-sonarjs/1.0.3?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![adoption](https://developer.mend.io/api/mc/badges/adoption/npm/eslint-plugin-sonarjs/1.0.3?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![passing](https://developer.mend.io/api/mc/badges/compatibility/npm/eslint-plugin-sonarjs/0.25.1/1.0.3?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![confidence](https://developer.mend.io/api/mc/badges/confidence/npm/eslint-plugin-sonarjs/0.25.1/1.0.3?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|

---

### Release Notes

<details>
<summary>SonarSource/eslint-plugin-sonarjs
(eslint-plugin-sonarjs)</summary>

###
[`v1.0.3`](https://togithub.com/SonarSource/eslint-plugin-sonarjs/compare/v1.0.2...004d7944672f249000e1eb1c97acd13e31e455eb)

[Compare
Source](https://togithub.com/SonarSource/eslint-plugin-sonarjs/compare/v1.0.2...1.0.3)

###
[`v1.0.2`](https://togithub.com/SonarSource/eslint-plugin-sonarjs/releases/tag/v1.0.2)

[Compare
Source](https://togithub.com/SonarSource/eslint-plugin-sonarjs/compare/1.0.0...v1.0.2)

#### What's Changed

- Export "meta" for plugin by
[@&#8203;zglicz](https://togithub.com/zglicz) in
[https://github.com/SonarSource/eslint-plugin-sonarjs/pull/472](https://togithub.com/SonarSource/eslint-plugin-sonarjs/pull/472)

###
[`v1.0.0`](https://togithub.com/SonarSource/eslint-plugin-sonarjs/releases/tag/1.0.0)

[Compare
Source](https://togithub.com/SonarSource/eslint-plugin-sonarjs/compare/0.25.1...1.0.0)

Eslint-plugin-sonarjs is compatible with ESLint v9.

##### What's Changed

- Migrate to all newest packages, except for eslint v9 by
[@&#8203;zglicz](https://togithub.com/zglicz) in
[https://github.com/SonarSource/eslint-plugin-sonarjs/pull/460](https://togithub.com/SonarSource/eslint-plugin-sonarjs/pull/460)
- Move from a compile-all to a compile-entry-point pattern by
[@&#8203;ericmorand-sonarsource](https://togithub.com/ericmorand-sonarsource)
in
[https://github.com/SonarSource/eslint-plugin-sonarjs/pull/463](https://togithub.com/SonarSource/eslint-plugin-sonarjs/pull/463)
- ESLINTJS-36 Split out tests and analyze into separate steps by
[@&#8203;zglicz](https://togithub.com/zglicz) in
[https://github.com/SonarSource/eslint-plugin-sonarjs/pull/465](https://togithub.com/SonarSource/eslint-plugin-sonarjs/pull/465)
- Fix breaking no-one-iteration-loop after ESLint v9 breaking change by
[@&#8203;zglicz](https://togithub.com/zglicz) in
[https://github.com/SonarSource/eslint-plugin-sonarjs/pull/467](https://togithub.com/SonarSource/eslint-plugin-sonarjs/pull/467)
- Resolve ESLINTJS-37 by
[@&#8203;ericmorand-sonarsource](https://togithub.com/ericmorand-sonarsource)
in
[https://github.com/SonarSource/eslint-plugin-sonarjs/pull/466](https://togithub.com/SonarSource/eslint-plugin-sonarjs/pull/466)
- Add ruling tests to handle eslint 8 and 9 by
[@&#8203;zglicz](https://togithub.com/zglicz) in
[https://github.com/SonarSource/eslint-plugin-sonarjs/pull/468](https://togithub.com/SonarSource/eslint-plugin-sonarjs/pull/468)
- Make the exported rules a typed record by
[@&#8203;ericmorand-sonarsource](https://togithub.com/ericmorand-sonarsource)
in
[https://github.com/SonarSource/eslint-plugin-sonarjs/pull/469](https://togithub.com/SonarSource/eslint-plugin-sonarjs/pull/469)

**Full Changelog**:
SonarSource/eslint-plugin-sonarjs@0.25.1...1.0.0

</details>

---

### Configuration

📅 **Schedule**: Branch creation - "every weekday" in timezone Etc/UTC,
Automerge - At any time (no schedule defined).

🚦 **Automerge**: Enabled.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the
rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update
again.

---

- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check
this box

---

This PR has been generated by [Mend
Renovate](https://www.mend.io/free-developer-tools/renovate/). View
repository job log
[here](https://developer.mend.io/github/ScaleLeap/amazon-marketplaces).

<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4zNDAuMTAiLCJ1cGRhdGVkSW5WZXIiOiIzNy4zNDAuMTAiLCJ0YXJnZXRCcmFuY2giOiJtYXN0ZXIiLCJsYWJlbHMiOlsicmVub3ZhdGVib3QiXX0=-->

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
mattgodbolt referenced this pull request in compiler-explorer/compiler-explorer Jun 11, 2024
@renovate
chore(deps): update dependency eslint-plugin-sonarjs to v1 (#6578)
d8d4f57 
[![Mend
Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com)

This PR contains the following updates:

| Package | Change | Age | Adoption | Passing | Confidence |
|---|---|---|---|---|---|
|
[eslint-plugin-sonarjs](https://togithub.com/SonarSource/eslint-plugin-sonarjs)
| [`^0.25.1` ->
`^1.0.3`](https://renovatebot.com/diffs/npm/eslint-plugin-sonarjs/0.25.1/1.0.3)
|
[![age](https://developer.mend.io/api/mc/badges/age/npm/eslint-plugin-sonarjs/1.0.3?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![adoption](https://developer.mend.io/api/mc/badges/adoption/npm/eslint-plugin-sonarjs/1.0.3?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![passing](https://developer.mend.io/api/mc/badges/compatibility/npm/eslint-plugin-sonarjs/0.25.1/1.0.3?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![confidence](https://developer.mend.io/api/mc/badges/confidence/npm/eslint-plugin-sonarjs/0.25.1/1.0.3?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|

---

### Release Notes

<details>
<summary>SonarSource/eslint-plugin-sonarjs
(eslint-plugin-sonarjs)</summary>

###
[`v1.0.3`](https://togithub.com/SonarSource/eslint-plugin-sonarjs/releases/tag/1.0.3)

[Compare
Source](https://togithub.com/SonarSource/eslint-plugin-sonarjs/compare/v1.0.2...1.0.3)

#### What's Changed

- [ESLINTJS-41](https://sonarsource.atlassian.net/browse/ESLINTJS-41)
The package entry points are incorrectly set by
[@&#8203;zglicz](https://togithub.com/zglicz) in
[https://github.com/SonarSource/eslint-plugin-sonarjs/pull/473](https://togithub.com/SonarSource/eslint-plugin-sonarjs/pull/473)

###
[`v1.0.2`](https://togithub.com/SonarSource/eslint-plugin-sonarjs/releases/tag/v1.0.2)

[Compare
Source](https://togithub.com/SonarSource/eslint-plugin-sonarjs/compare/1.0.0...v1.0.2)

#### What's Changed

- [ESLINTJS-40](https://sonarsource.atlassian.net/browse/ESLINTJS-40)
Expose the plugin "meta" as expected by ESLint 9 by
[@&#8203;zglicz](https://togithub.com/zglicz) in
[https://github.com/SonarSource/eslint-plugin-sonarjs/pull/472](https://togithub.com/SonarSource/eslint-plugin-sonarjs/pull/472)

###
[`v1.0.0`](https://togithub.com/SonarSource/eslint-plugin-sonarjs/releases/tag/1.0.0)

[Compare
Source](https://togithub.com/SonarSource/eslint-plugin-sonarjs/compare/0.25.1...1.0.0)

Eslint-plugin-sonarjs is compatible with ESLint v9.

##### What's Changed

- Migrate to all newest packages, except for eslint v9 by
[@&#8203;zglicz](https://togithub.com/zglicz) in
[https://github.com/SonarSource/eslint-plugin-sonarjs/pull/460](https://togithub.com/SonarSource/eslint-plugin-sonarjs/pull/460)
- Move from a compile-all to a compile-entry-point pattern by
[@&#8203;ericmorand-sonarsource](https://togithub.com/ericmorand-sonarsource)
in
[https://github.com/SonarSource/eslint-plugin-sonarjs/pull/463](https://togithub.com/SonarSource/eslint-plugin-sonarjs/pull/463)
- ESLINTJS-36 Split out tests and analyze into separate steps by
[@&#8203;zglicz](https://togithub.com/zglicz) in
[https://github.com/SonarSource/eslint-plugin-sonarjs/pull/465](https://togithub.com/SonarSource/eslint-plugin-sonarjs/pull/465)
- Fix breaking no-one-iteration-loop after ESLint v9 breaking change by
[@&#8203;zglicz](https://togithub.com/zglicz) in
[https://github.com/SonarSource/eslint-plugin-sonarjs/pull/467](https://togithub.com/SonarSource/eslint-plugin-sonarjs/pull/467)
- Resolve ESLINTJS-37 by
[@&#8203;ericmorand-sonarsource](https://togithub.com/ericmorand-sonarsource)
in
[https://github.com/SonarSource/eslint-plugin-sonarjs/pull/466](https://togithub.com/SonarSource/eslint-plugin-sonarjs/pull/466)
- Add ruling tests to handle eslint 8 and 9 by
[@&#8203;zglicz](https://togithub.com/zglicz) in
[https://github.com/SonarSource/eslint-plugin-sonarjs/pull/468](https://togithub.com/SonarSource/eslint-plugin-sonarjs/pull/468)
- Make the exported rules a typed record by
[@&#8203;ericmorand-sonarsource](https://togithub.com/ericmorand-sonarsource)
in
[https://github.com/SonarSource/eslint-plugin-sonarjs/pull/469](https://togithub.com/SonarSource/eslint-plugin-sonarjs/pull/469)

**Full Changelog**:
SonarSource/eslint-plugin-sonarjs@0.25.1...1.0.0

</details>

---

### Configuration

📅 **Schedule**: Branch creation - "before 8pm on the first day of the
month" in timezone America/Chicago, Automerge - At any time (no schedule
defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you
are satisfied.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the
rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update
again.

---

- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check
this box

---

This PR has been generated by [Mend
Renovate](https://www.mend.io/free-developer-tools/renovate/). View
repository job log
[here](https://developer.mend.io/github/compiler-explorer/compiler-explorer).

<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4zOTMuMCIsInVwZGF0ZWRJblZlciI6IjM3LjM5My4wIiwidGFyZ2V0QnJhbmNoIjoibWFpbiIsImxhYmVscyI6W119-->

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
mattgodbolt referenced this pull request in compiler-explorer/compiler-explorer Jun 11, 2024
@renovate @mattgodbolt
chore(deps): update dependency eslint-plugin-sonarjs to v1 (#6578)
f515a17 
[![Mend
Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com)

This PR contains the following updates:

| Package | Change | Age | Adoption | Passing | Confidence |
|---|---|---|---|---|---|
|
[eslint-plugin-sonarjs](https://togithub.com/SonarSource/eslint-plugin-sonarjs)
| [`^0.25.1` ->
`^1.0.3`](https://renovatebot.com/diffs/npm/eslint-plugin-sonarjs/0.25.1/1.0.3)
|
[![age](https://developer.mend.io/api/mc/badges/age/npm/eslint-plugin-sonarjs/1.0.3?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![adoption](https://developer.mend.io/api/mc/badges/adoption/npm/eslint-plugin-sonarjs/1.0.3?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![passing](https://developer.mend.io/api/mc/badges/compatibility/npm/eslint-plugin-sonarjs/0.25.1/1.0.3?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![confidence](https://developer.mend.io/api/mc/badges/confidence/npm/eslint-plugin-sonarjs/0.25.1/1.0.3?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|

---

### Release Notes

<details>
<summary>SonarSource/eslint-plugin-sonarjs
(eslint-plugin-sonarjs)</summary>

###
[`v1.0.3`](https://togithub.com/SonarSource/eslint-plugin-sonarjs/releases/tag/1.0.3)

[Compare
Source](https://togithub.com/SonarSource/eslint-plugin-sonarjs/compare/v1.0.2...1.0.3)

#### What's Changed

- [ESLINTJS-41](https://sonarsource.atlassian.net/browse/ESLINTJS-41)
The package entry points are incorrectly set by
[@&#8203;zglicz](https://togithub.com/zglicz) in
[https://github.com/SonarSource/eslint-plugin-sonarjs/pull/473](https://togithub.com/SonarSource/eslint-plugin-sonarjs/pull/473)

###
[`v1.0.2`](https://togithub.com/SonarSource/eslint-plugin-sonarjs/releases/tag/v1.0.2)

[Compare
Source](https://togithub.com/SonarSource/eslint-plugin-sonarjs/compare/1.0.0...v1.0.2)

#### What's Changed

- [ESLINTJS-40](https://sonarsource.atlassian.net/browse/ESLINTJS-40)
Expose the plugin "meta" as expected by ESLint 9 by
[@&#8203;zglicz](https://togithub.com/zglicz) in
[https://github.com/SonarSource/eslint-plugin-sonarjs/pull/472](https://togithub.com/SonarSource/eslint-plugin-sonarjs/pull/472)

###
[`v1.0.0`](https://togithub.com/SonarSource/eslint-plugin-sonarjs/releases/tag/1.0.0)

[Compare
Source](https://togithub.com/SonarSource/eslint-plugin-sonarjs/compare/0.25.1...1.0.0)

Eslint-plugin-sonarjs is compatible with ESLint v9.

##### What's Changed

- Migrate to all newest packages, except for eslint v9 by
[@&#8203;zglicz](https://togithub.com/zglicz) in
[https://github.com/SonarSource/eslint-plugin-sonarjs/pull/460](https://togithub.com/SonarSource/eslint-plugin-sonarjs/pull/460)
- Move from a compile-all to a compile-entry-point pattern by
[@&#8203;ericmorand-sonarsource](https://togithub.com/ericmorand-sonarsource)
in
[https://github.com/SonarSource/eslint-plugin-sonarjs/pull/463](https://togithub.com/SonarSource/eslint-plugin-sonarjs/pull/463)
- ESLINTJS-36 Split out tests and analyze into separate steps by
[@&#8203;zglicz](https://togithub.com/zglicz) in
[https://github.com/SonarSource/eslint-plugin-sonarjs/pull/465](https://togithub.com/SonarSource/eslint-plugin-sonarjs/pull/465)
- Fix breaking no-one-iteration-loop after ESLint v9 breaking change by
[@&#8203;zglicz](https://togithub.com/zglicz) in
[https://github.com/SonarSource/eslint-plugin-sonarjs/pull/467](https://togithub.com/SonarSource/eslint-plugin-sonarjs/pull/467)
- Resolve ESLINTJS-37 by
[@&#8203;ericmorand-sonarsource](https://togithub.com/ericmorand-sonarsource)
in
[https://github.com/SonarSource/eslint-plugin-sonarjs/pull/466](https://togithub.com/SonarSource/eslint-plugin-sonarjs/pull/466)
- Add ruling tests to handle eslint 8 and 9 by
[@&#8203;zglicz](https://togithub.com/zglicz) in
[https://github.com/SonarSource/eslint-plugin-sonarjs/pull/468](https://togithub.com/SonarSource/eslint-plugin-sonarjs/pull/468)
- Make the exported rules a typed record by
[@&#8203;ericmorand-sonarsource](https://togithub.com/ericmorand-sonarsource)
in
[https://github.com/SonarSource/eslint-plugin-sonarjs/pull/469](https://togithub.com/SonarSource/eslint-plugin-sonarjs/pull/469)

**Full Changelog**:
SonarSource/eslint-plugin-sonarjs@0.25.1...1.0.0

</details>

---

### Configuration

📅 **Schedule**: Branch creation - "before 8pm on the first day of the
month" in timezone America/Chicago, Automerge - At any time (no schedule
defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you
are satisfied.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the
rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update
again.

---

- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check
this box

---

This PR has been generated by [Mend
Renovate](https://www.mend.io/free-developer-tools/renovate/). View
repository job log
[here](https://developer.mend.io/github/compiler-explorer/compiler-explorer).

<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4zOTMuMCIsInVwZGF0ZWRJblZlciI6IjM3LjM5My4wIiwidGFyZ2V0QnJhbmNoIjoibWFpbiIsImxhYmVscyI6W119-->

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
OfekShilon referenced this pull request in OfekShilon/compiler-explorer Jul 13, 2024
@renovate @OfekShilon
chore(deps): update dependency eslint-plugin-sonarjs to v1 (compiler-…
a8879b1 
…explorer#6578)

[![Mend
Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com)

This PR contains the following updates:

| Package | Change | Age | Adoption | Passing | Confidence |
|---|---|---|---|---|---|
|
[eslint-plugin-sonarjs](https://togithub.com/SonarSource/eslint-plugin-sonarjs)
| [`^0.25.1` ->
`^1.0.3`](https://renovatebot.com/diffs/npm/eslint-plugin-sonarjs/0.25.1/1.0.3)
|
[![age](https://developer.mend.io/api/mc/badges/age/npm/eslint-plugin-sonarjs/1.0.3?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![adoption](https://developer.mend.io/api/mc/badges/adoption/npm/eslint-plugin-sonarjs/1.0.3?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![passing](https://developer.mend.io/api/mc/badges/compatibility/npm/eslint-plugin-sonarjs/0.25.1/1.0.3?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![confidence](https://developer.mend.io/api/mc/badges/confidence/npm/eslint-plugin-sonarjs/0.25.1/1.0.3?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|

---

### Release Notes

<details>
<summary>SonarSource/eslint-plugin-sonarjs
(eslint-plugin-sonarjs)</summary>

###
[`v1.0.3`](https://togithub.com/SonarSource/eslint-plugin-sonarjs/releases/tag/1.0.3)

[Compare
Source](https://togithub.com/SonarSource/eslint-plugin-sonarjs/compare/v1.0.2...1.0.3)

#### What's Changed

- [ESLINTJS-41](https://sonarsource.atlassian.net/browse/ESLINTJS-41)
The package entry points are incorrectly set by
[@&#8203;zglicz](https://togithub.com/zglicz) in
[https://github.com/SonarSource/eslint-plugin-sonarjs/pull/473](https://togithub.com/SonarSource/eslint-plugin-sonarjs/pull/473)

###
[`v1.0.2`](https://togithub.com/SonarSource/eslint-plugin-sonarjs/releases/tag/v1.0.2)

[Compare
Source](https://togithub.com/SonarSource/eslint-plugin-sonarjs/compare/1.0.0...v1.0.2)

#### What's Changed

- [ESLINTJS-40](https://sonarsource.atlassian.net/browse/ESLINTJS-40)
Expose the plugin "meta" as expected by ESLint 9 by
[@&#8203;zglicz](https://togithub.com/zglicz) in
[https://github.com/SonarSource/eslint-plugin-sonarjs/pull/472](https://togithub.com/SonarSource/eslint-plugin-sonarjs/pull/472)

###
[`v1.0.0`](https://togithub.com/SonarSource/eslint-plugin-sonarjs/releases/tag/1.0.0)

[Compare
Source](https://togithub.com/SonarSource/eslint-plugin-sonarjs/compare/0.25.1...1.0.0)

Eslint-plugin-sonarjs is compatible with ESLint v9.

##### What's Changed

- Migrate to all newest packages, except for eslint v9 by
[@&#8203;zglicz](https://togithub.com/zglicz) in
[https://github.com/SonarSource/eslint-plugin-sonarjs/pull/460](https://togithub.com/SonarSource/eslint-plugin-sonarjs/pull/460)
- Move from a compile-all to a compile-entry-point pattern by
[@&#8203;ericmorand-sonarsource](https://togithub.com/ericmorand-sonarsource)
in
[https://github.com/SonarSource/eslint-plugin-sonarjs/pull/463](https://togithub.com/SonarSource/eslint-plugin-sonarjs/pull/463)
- ESLINTJS-36 Split out tests and analyze into separate steps by
[@&#8203;zglicz](https://togithub.com/zglicz) in
[https://github.com/SonarSource/eslint-plugin-sonarjs/pull/465](https://togithub.com/SonarSource/eslint-plugin-sonarjs/pull/465)
- Fix breaking no-one-iteration-loop after ESLint v9 breaking change by
[@&#8203;zglicz](https://togithub.com/zglicz) in
[https://github.com/SonarSource/eslint-plugin-sonarjs/pull/467](https://togithub.com/SonarSource/eslint-plugin-sonarjs/pull/467)
- Resolve ESLINTJS-37 by
[@&#8203;ericmorand-sonarsource](https://togithub.com/ericmorand-sonarsource)
in
[https://github.com/SonarSource/eslint-plugin-sonarjs/pull/466](https://togithub.com/SonarSource/eslint-plugin-sonarjs/pull/466)
- Add ruling tests to handle eslint 8 and 9 by
[@&#8203;zglicz](https://togithub.com/zglicz) in
[https://github.com/SonarSource/eslint-plugin-sonarjs/pull/468](https://togithub.com/SonarSource/eslint-plugin-sonarjs/pull/468)
- Make the exported rules a typed record by
[@&#8203;ericmorand-sonarsource](https://togithub.com/ericmorand-sonarsource)
in
[https://github.com/SonarSource/eslint-plugin-sonarjs/pull/469](https://togithub.com/SonarSource/eslint-plugin-sonarjs/pull/469)

**Full Changelog**:
SonarSource/eslint-plugin-sonarjs@0.25.1...1.0.0

</details>

---

### Configuration

📅 **Schedule**: Branch creation - "before 8pm on the first day of the
month" in timezone America/Chicago, Automerge - At any time (no schedule
defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you
are satisfied.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the
rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update
again.

---

- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check
this box

---

This PR has been generated by [Mend
Renovate](https://www.mend.io/free-developer-tools/renovate/). View
repository job log
[here](https://developer.mend.io/github/compiler-explorer/compiler-explorer).

<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4zOTMuMCIsInVwZGF0ZWRJblZlciI6IjM3LjM5My4wIiwidGFyZ2V0QnJhbmNoIjoibWFpbiIsImxhYmVscyI6W119-->

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@zglicz zglicz zglicz approved these changes

@vdiez vdiez Awaiting requested review from vdiez

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.0.0
Development

Successfully merging this pull request may close these issues.
2 participants
@ericmorand-sonarsource @zglicz