JS-400 Single entrypoint for worker and server

[vdiez]

JS-400

[sonarqube-next]

Quality Gate passed

Issues
0 New issues
0 Fixed issues
2 Accepted issues

Measures
0 Security Hotspots
94.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube

[ericmorand-sonarsource]

I find the pattern strange, and more generally, I don't see why we need a different script for the server and the worker.

I would have gone with this pattern:

#!/usr/bin/env node
import { Worker, isMainThread, parentPort }  from "node:worker_threads";

if (isMainThread) {
  // this is the parent, aka the CLI script
  const worker = new Worker(import.meta.filename);

  worker.once("message", (message) => {
    console.log('The worker did its thing', message);
  });

  worker.postMessage('Do something');
}
else {
  // this is the worker
  console.log('ParentPort is guaranteed to exist since we are not in the main thread');

  parentPort.once("message", (message) => {
    if (message === 'Do something') {
      parentPort.postMessage("I did what I am supposed to do");
    }
  });
}

There seems to be some partial implementation of this pattern - the isMainThread in server.mjs and the if (parentPort) in worker.ts - which adds to the confusion.

[zglicz]

lgtm

[zglicz]

Is this comment @param type helping?

[zglicz]

no curly braces around multiple statements? or is an if simple enough?