Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

JS-389 Add missing license and clean up #4890

Merged
merged 1 commit into from
Nov 4, 2024
Merged

JS-389 Add missing license and clean up #4890

merged 1 commit into from
Nov 4, 2024

Conversation

yassin-kammoun-sonarsource
Copy link
Contributor

@yassin-kammoun-sonarsource yassin-kammoun-sonarsource commented Nov 4, 2024 •
edited by jira bot
Loading

@hashicorp-vault-sonar-prod hashicorp-vault-sonar-prod bot changed the title Clean up JS-389 Clean up Nov 4, 2024
@sonarqube-next SonarQube-Next
Copy link

sonarqube-next bot commented Nov 4, 2024

Quality Gate passed Quality Gate passed

Issues
0 New issues
3 Fixed issues
0 Accepted issues

Measures
0 Security Hotspots
100.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube

@yassin-kammoun-sonarsource yassin-kammoun-sonarsource requested a review from a team November 4, 2024 13:32
@yassin-kammoun-sonarsource yassin-kammoun-sonarsource changed the title JS-389 Clean up JS-389 Add missing license and clean up Nov 4, 2024
kebetsi
kebetsi approved these changes Nov 4, 2024
View reviewed changes
Copy link
Contributor

@kebetsi kebetsi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yassin-kammoun-sonarsource yassin-kammoun-sonarsource merged commit 5a93a39 into master Nov 4, 2024
18 of 20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kebetsi kebetsi kebetsi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@yassin-kammoun-sonarsource @kebetsi