JS-385 Fix SonarLint ITS #4889
JS-385 Fix SonarLint ITS #4889
Conversation
hashicorp-vault-sonar-prod
bot
changed the title
|
There was a problem hiding this comment.
Nice, also the tests take 9 minutes now. Makes more sense.
[INFO] ------------------------------------------------------- [INFO] T E S T S [INFO] ------------------------------------------------------- [INFO] Running com.sonar.javascript.it.plugin.sonarlint.tests.SonarLintTest [INFO] Tests run: 10, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 459.2 s -- in com.sonar.javascript.it.plugin.sonarlint.tests.SonarLintTest [INFO] Running com.sonar.javascript.it.plugin.sonarlint.tests.SonarLintTestCodeAnalysisTest [INFO] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 49.52 s -- in com.sonar.javascript.it.plugin.sonarlint.tests.SonarLintTestCodeAnalysisTest [INFO]
| @@ -61,14 +60,6 @@ private static Pattern pluginFilenameMatcher() { | |||
| : Pattern.compile("sonar-javascript-plugin-[0-9.]*(?:-SNAPSHOT)?\\.jar"); | |||
| } | |||
|
|
|||
| public static Path homeDir() { | |||
| try { | |||
| return Path.of(requireNonNull(TestUtils.class.getResource("TestUtils.txt")).toURI()); | |||
There was a problem hiding this comment.
couldn't make this work, huh?
There was a problem hiding this comment.
we could, but @alban-auzeill mentioned that it makes no sense to use the path of an existing resource to build the homedir, and it's much easier to go directly to the artifact path, as we know where it is. This homeDir method was only used to locate the artifact.
JS-385