JS-255 Restore cognitive complexity calculation at file level #4833
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yassin-kammoun-sonarsource
force-pushed
the
JS-255
branch
from
5f465e5 to
2d4deac
Compare
yassin-kammoun-sonarsource
force-pushed
the
JS-255
branch
from
2d4deac to
161d44a
Compare
|
zglicz
approved these changes
Sep 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The complexity calculation at file level is restored to its previous state the SonarJS ESLint plugin before this change. However, when the rule is activated for cognitive complexity at the function level, the new behavior for a nesting function that does not account for its nested function's complexity is preserved. The RSPEC of the rule was also slightly improved.
It might not be obvious to review this PR. I think that the changes on the unit test assertions and the absence of changes in the ruling is proof enough that everything is working as it should. Therefore, reviewing those might be enough.
Last but not least, I think the rule should be implemented from scratch as it's becoming quite difficult to understand what it actually does. However, I suggest we postpone this to later and create a ticket for this.