Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JS-85 Update usages of old apis #4821

Merged
merged 3 commits into from
Sep 18, 2024
Merged

JS-85 Update usages of old apis #4821

merged 3 commits into from
Sep 18, 2024

Conversation

zglicz
Copy link
Contributor

@zglicz zglicz commented Sep 17, 2024

No description provided.

Comment on lines -11 to -18
123,
123,
134,
134,
194,
194,
242,
270
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have mixed feelings about this. We stopped raising more issues as we probably aren't as thorough as the previous rule was, when it was getting the context.getScope() -> called on Program:exit. However, I've checked the issues we stopped triggering on and it was only on the same variables, so maybe it's alright.

Copy link
Contributor

@vdiez vdiez Sep 17, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

context.sourceCode.getScope(node) now returns a different scope as it depends on the node we give as argument.

In the decorator, we only have the node that is raising the issue. Before, calling context.getScope() returned the scope of node in selector, but from the decorator we don't know what node that is.

@zglicz zglicz merged commit 4a83af3 into master Sep 18, 2024
15 of 16 checks passed
@zglicz zglicz deleted the eslintv9 branch September 18, 2024 10:16
zglicz added a commit that referenced this pull request Sep 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants