JS-185 Deeply nested ASTs should be de-serialized correctly #4762
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
quentin-jaquier-sonarsource
force-pushed
the
qj/JS-185
branch
from
f29e582
to
adfaffd
Compare
quentin-jaquier-sonarsource
force-pushed
the
qj/JS-185
branch
from
adfaffd
to
9069ea0
Compare
| * It makes sense as a general default limit for protobuf users, but in our case, we are producing the input ourselves, | ||
| * and even if users are controlling the code, it is not a new security risk, as any analyzer would have to deal with the same limit. | ||
| */ | ||
| private static final int PROTOBUF_RECURSION_LIMIT = 300; |
There was a problem hiding this comment.
The onion benchmark worst case hits 90 layers (180 in terms of Protobuf messages).
Knowing that it is already "fake" code, I feel that if user-defined code ever hits 300, it is fair to not even try to do anything with it...
renaud-tognelli-sonarsource
approved these changes
Jul 29, 2024
sonar-plugin/bridge/src/main/java/org/sonar/plugins/javascript/bridge/FormDataUtils.java
Outdated
Show resolved
Hide resolved
…/bridge/FormDataUtils.java Co-authored-by: Renaud T. <125455319+renaud-tognelli-sonarsource@users.noreply.github.com>
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.