Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JS-193 Add missing body property to static block #4741

Merged

Conversation

ilia-kebets-sonarsource
Copy link
Contributor

No description provided.

Copy link

sonarqube-next bot commented Jun 18, 2024

@ilia-kebets-sonarsource
Copy link
Contributor Author

@quentin-jaquier-sonarsource Do you think we should address this issue and reuse the visitBlockStatement() function (probably renaming it to something like visitBlock()) as the issue suggests or accept the duplication?

@quentin-jaquier-sonarsource
Copy link
Contributor

I personally think this file is an exception to the rule, I don't think it makes sense to address the issue. The motivation is that I would prefer to have an exhaustive list of methods, rather than merging two methods. We already apply this logic for other methods.

@quentin-jaquier-sonarsource quentin-jaquier-sonarsource merged commit 7d09293 into master Jun 18, 2024
17 of 18 checks passed
@quentin-jaquier-sonarsource quentin-jaquier-sonarsource deleted the JS-193-add-missing-body-to-static-block branch June 18, 2024 10:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants