JS-186 ESTree AST should not be serialized when Armor is disabled

its/plugin/tests/src/test/java/com/sonar/javascript/it/plugin/ConsumerPluginTest.java

@@ -80,6 +80,8 @@ static BuildResult runBuild(Orchestrator orchestrator) {
       .setProjectName("Custom Rules")
       .setProjectVersion("1.0")
       .setDebugLogs(true)
+      // This flag is an intermediate solution to not run Armor for all projects during the development of the new analyzer.
+      .setProperty("sonar.armor.internal.enabled", "true")
       .setSourceDirs("src");
     orchestrator.getServer().provisionProject("custom-rules", "Custom Rules");
     orchestrator

sonar-plugin/sonar-javascript-plugin/src/main/java/org/sonar/plugins/javascript/analysis/AbstractAnalysis.java

@@ -102,7 +102,7 @@ protected void analyzeFile(InputFile file, @Nullable List<String> tsConfigs, @Nu
         LOG.debug("Analyzing file: {}", file.uri());
         progressReport.nextFile(file.toString());
         var fileContent = contextUtils.shouldSendFileContent(file) ? file.contents() : null;
-        var skipAst = !consumers.hasConsumers();
+        var skipAst = !consumers.hasConsumers() || !contextUtils.isSonarArmorEnabled();
         var request = getJsAnalysisRequest(file, fileContent, tsProgram, tsConfigs, skipAst);
 
         var response = isJavaScript(file)

sonar-plugin/sonar-javascript-plugin/src/main/java/org/sonar/plugins/javascript/analysis/ContextUtils.java

@@ -27,6 +27,9 @@
 
 class ContextUtils {
 
+  /* Internal property to enable Armor (disabled by default) */
+  private static final String ARMOR_INTERNAL_ENABLED = "sonar.armor.internal.enabled";
+
   private final SensorContext context;
 
   ContextUtils(SensorContext context) {
@@ -59,4 +62,8 @@ boolean failFast() {
   SensorContext context() {
     return context;
   }
+
+  boolean isSonarArmorEnabled() {
+    return context.config().getBoolean(ARMOR_INTERNAL_ENABLED).orElse(false);
+  }
 }

sonar-plugin/sonar-javascript-plugin/src/test/java/org/sonar/plugins/javascript/analysis/JsTsSensorTest.java

@@ -386,6 +386,7 @@ void should_send_skipAst_flag_when_there_are_no_consumers() throws Exception {
   @Test
   void should_not_send_the_skipAst_flag_when_there_are_consumers() throws Exception {
     var ctx = createSensorContext(baseDir);
+    ctx.setSettings(new MapSettings().setProperty("sonar.armor.internal.enabled", "true"));
     var inputFile = createInputFile(ctx);
     var tsProgram = new TsProgram("1", List.of(inputFile.absolutePath()), List.of());
     var consumer = createConsumer();
@@ -400,6 +401,24 @@ void should_not_send_the_skipAst_flag_when_there_are_consumers() throws Exceptio
     assertThat(captor.getValue().skipAst()).isFalse();
   }
 
+  @Test
+  void should_send_the_skipAst_flag_when_there_are_consumers_but_armor_is_disabled() throws Exception {
+    var ctx = createSensorContext(baseDir);
+    ctx.setSettings(new MapSettings().setProperty("sonar.armor.internal.enabled", "false"));
+    var inputFile = createInputFile(ctx);
+    var tsProgram = new TsProgram("1", List.of(inputFile.absolutePath()), List.of());
+    var consumer = createConsumer();
+    var sensor = createSensorWithConsumer(consumer);
+    when(bridgeServerMock.createProgram(any())).thenReturn(tsProgram);
+    when(bridgeServerMock.analyzeTypeScript(any())).thenReturn(new AnalysisResponse());
+    sensor.execute(ctx);
+
+    createSensor().execute(context);
+    var captor = ArgumentCaptor.forClass(JsAnalysisRequest.class);
+    verify(bridgeServerMock).analyzeTypeScript(captor.capture());
+    assertThat(captor.getValue().skipAst()).isTrue();
+  }
+
   @Test
   void should_send_content_when_not_utf8() throws Exception {
     var ctx = createSensorContext(baseDir);