-
Notifications
You must be signed in to change notification settings - Fork 182
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
JS-160 Create Java based AST #4731
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
saberduck
commented
Jun 7, 2024
•
edited
Loading
edited
- missing handling of literals
- needs tests obviously :/
saberduck
changed the base branch from
master
to
JS-159-send-real-AST-using-protobuf
June 7, 2024 15:53
quentin-jaquier-sonarsource
force-pushed
the
JS-160
branch
from
June 10, 2024 07:54
6682d1c
to
2d49506
Compare
Co-authored-by: Quentin Jaquier <quentin.jaquier@sonarsource.com>
...-javascript-plugin/src/main/java/org/sonar/plugins/javascript/analysis/AbstractAnalysis.java
Outdated
Show resolved
Hide resolved
sonar-plugin/bridge/src/test/java/org/sonar/plugins/javascript/bridge/ESTreeFactoryTest.java
Show resolved
Hide resolved
sonar-plugin/bridge/src/main/java/org/sonar/plugins/javascript/bridge/ESTreeFactory.java
Show resolved
Hide resolved
…lugins/javascript/analysis/AbstractAnalysis.java
ilia-kebets-sonarsource
approved these changes
Jun 12, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we reviewed together with @quentin-jaquier-sonarsource
quentin-jaquier-sonarsource
approved these changes
Jun 12, 2024
hashicorp-vault-sonar-prod
bot
assigned saberduck and unassigned ilia-kebets-sonarsource and saberduck
Jun 12, 2024
Quality Gate passedIssues Measures |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.