JS-164 Improve S5122: Detect origin reflection #4724
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ilia-kebets-sonarsource
approved these changes
Jun 5, 2024
yassin-kammoun-sonarsource
force-pushed
the
JS-164
branch
from
b2b9ea6 to
34a2190
Compare
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The rule was reimplemented from scratch.
It now leverages helper functions implemented in the meantime.
It makes the rule smarter, more reliable, and less noisy.
I have checked locally and confirmed that the original vulnerability reported by the R&D Team is now being detected.
Please review also the RSPEC update: SonarSource/rspec#3963