JS-163 New Java API to process files during the analysis #4706
Conversation
...in/plugins/consumer-plugin/src/main/java/org/sonar/samples/javascript/consumer/Consumer.java
Show resolved
Hide resolved
|
| } | ||
|
|
||
| protected boolean isJavaScript(InputFile file) { | ||
| return inputFileLanguage(file).equals(JavaScriptLanguage.KEY); | ||
| } | ||
|
|
||
| abstract void analyzeFiles(List<InputFile> inputFiles, List<String> tsConfigs) throws IOException; | ||
|
|
||
| protected void analyzeFile(InputFile file, @Nullable List<String> tsConfigs, @Nullable TsProgram tsProgram) throws IOException { |
There was a problem hiding this comment.
nice job of refactoring duplicate code into this!
| @Override | ||
| public void doneAnalysis() { | ||
| consumers.forEach(JsAnalysisConsumer::doneAnalysis); | ||
| } |
There was a problem hiding this comment.
doneAnalysis() is actually never used for the consumerS, only for each consumer individually?
There was a problem hiding this comment.
So this IT runs both the JS and Consumer plugins and validates that the consumer plugin runs execute() if and only if once the JS plugin is done processing all the files? Is that correct?
There was a problem hiding this comment.
yes, it is asserting that execute is invoked only after the analysis. The order of execution of sensors is implemented with DependsUpon/@DependedUpon annotation
Fixes JS-163