Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

JS-148 Fix deprecations #4681

Merged
merged 9 commits into from
May 7, 2024
Merged

JS-148 Fix deprecations #4681

merged 9 commits into from
May 7, 2024

Conversation

zglicz
Copy link
Contributor

@zglicz zglicz commented May 6, 2024 •
edited
Loading

No description provided.

@zglicz zglicz marked this pull request as ready for review May 7, 2024 09:02
@zglicz zglicz changed the title Fix deprecations JS-148 Fix deprecations May 7, 2024
@zglicz
Copy link
Contributor Author

zglicz commented May 7, 2024

We actually stopped flagging a false positive. It used to trigger an "unused assignment" (S1854) for this line of code: https://github.com/SonarSource/jsts-test-sources/blob/00c2ab49a7b1dd808bdf2ad6cfcc00bd8ed093ce/desktop/app/src/ui/lib/git-perf.ts#L28

@sonarqube-next SonarQube-Next
Copy link

sonarqube-next bot commented May 7, 2024

Quality Gate passed Quality Gate passed

Issues
0 New issues
0 Fixed issues
0 Accepted issues

Measures
0 Security Hotspots
98.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube

@zglicz zglicz merged commit 4c88bf1 into master May 7, 2024
14 checks passed
@zglicz zglicz deleted the depr branch May 7, 2024 15:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ericmorand-sonarsource ericmorand-sonarsource ericmorand-sonarsource approved these changes

Assignees

@zglicz zglicz

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@zglicz @ericmorand-sonarsource