Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Resolve JS-147 - Adapt SonarJS to the next ESLint Plugin #4677

Merged
merged 13 commits into from
May 1, 2024
Merged

Resolve JS-147 - Adapt SonarJS to the next ESLint Plugin #4677

merged 13 commits into from
May 1, 2024

Conversation

ericmorand-sonarsource
Copy link
Contributor

@ericmorand-sonarsource ericmorand-sonarsource commented Apr 29, 2024 •
edited
Loading

Fixes JS-147

@ericmorand-sonarsource ericmorand-sonarsource force-pushed the JS-147 branch 12 times, most recently from 3a3ab21 to 50fd7e3 Compare April 30, 2024 10:02
@ericmorand-sonarsource ericmorand-sonarsource marked this pull request as draft April 30, 2024 13:13
@ericmorand-sonarsource ericmorand-sonarsource changed the title [DRAFT] Minimal change needed to bring compatibility with next SonarJS ESLint plugin Minimal change needed to bring compatibility with next SonarJS ESLint plugin Apr 30, 2024
@ericmorand-sonarsource
WIP
f116556 
Essentially, checking how the tests behave with just one change to bring compatibility with the next version of
SonarJS ESLing plugin.
@ericmorand-sonarsource ericmorand-sonarsource changed the title Minimal change needed to bring compatibility with next SonarJS ESLint plugin Resolve JS-147 May 1, 2024
@ericmorand-sonarsource ericmorand-sonarsource marked this pull request as ready for review May 1, 2024 11:20
@ericmorand-sonarsource ericmorand-sonarsource changed the title Resolve JS-147 Resolve JS-147 - Adapt SonarJS to the next ESLint Plugin May 1, 2024
zglicz
zglicz approved these changes May 1, 2024
View reviewed changes
Copy link
Contributor

@zglicz zglicz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense. Glad that this works!

package.json Outdated Show resolved Hide resolved
package.json
"builtin-modules": "3.3.0",
"bytes": "3.1.2",
"eslint": "8.57.0",
"eslint-plugin-import": "2.29.1",
"eslint-plugin-jsx-a11y": "6.8.0",
"eslint-plugin-react": "7.34.1",
"eslint-plugin-react-hooks": "4.6.0",
"eslint-plugin-sonarjs": "0.25.0",
"eslint-plugin-sonarjs": "^0.26.0-2918",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is this an internal only number? As in, it's not possible to get this version from npm

Copy link
Contributor Author

@ericmorand-sonarsource ericmorand-sonarsource May 1, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

True. When we push the 1.0.0 version, I propose that we update this accordingly.

packages/jsts/src/rules/S6647/rule.ts Outdated Show resolved Hide resolved
@sonarqube-next SonarQube-Next
Copy link

sonarqube-next bot commented May 1, 2024

Quality Gate passed Quality Gate passed

Issues
0 New issues
0 Fixed issues
0 Accepted issues

Measures
0 Security Hotspots
95.8% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube

@ericmorand-sonarsource ericmorand-sonarsource merged commit e91895f into SonarSource:master May 1, 2024
14 checks passed
@ericmorand-sonarsource ericmorand-sonarsource deleted the JS-147 branch May 1, 2024 15:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zglicz zglicz zglicz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ericmorand-sonarsource @zglicz