Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change message to suggest upgrading to LTS version and not mention minimum version #4611

Merged
merged 5 commits into from
Mar 27, 2024
Merged

Change message to suggest upgrading to LTS version and not mention minimum version #4611

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
0ac7b95
Change message to suggest upgrading to LTS version and not mention mi…
saberduck Mar 22, 2024
9519788
fix test
saberduck Mar 22, 2024
415740c
fix test
saberduck Mar 22, 2024
d32fdee
Update sonar-plugin/sonar-javascript-plugin/src/main/java/org/sonar/p…
saberduck Mar 27, 2024
00cfebc
review
saberduck Mar 27, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions ...ript-plugin/src/main/java/org/sonar/plugins/javascript/nodejs/NodeCommandBuilderImpl.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -182,8 +182,7 @@ private void checkNodeCompatibility(String nodeExecutable) throws NodeCommandExc
if (!actualNodeVersion.isGreaterThanOrEqual(minNodeVersion)) {
throw new NodeCommandException(
String.format(
"Only Node.js v%s or later is supported, got %s.",
minNodeVersion,
"Unsupported Node.JS version detected %s. Please upgrade to latest Node.JS LTS version.",
saberduck marked this conversation as resolved.
Show resolved Hide resolved
actualNodeVersion
)
);
Expand Down
4 changes: 3 additions & 1 deletion ...-javascript-plugin/src/test/java/org/sonar/plugins/javascript/nodejs/NodeCommandTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -112,7 +112,9 @@ void test_min_version() throws IOException {
builder().minNodeVersion(Version.create(99, 0)).pathResolver(getPathResolver()).build()
)
.isInstanceOf(NodeCommandException.class)
.hasMessageStartingWith("Only Node.js v99.0 or later is supported, got");
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

well, this was future-proof

.hasMessageMatching(
"Unsupported Node.JS version detected .* Please upgrade to latest Node.JS LTS version."
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same as above

);
}

@Test
Expand Down
Loading