Analysis should not fail when highlighting has invalid text range #4604
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| TypeOfText.valueOf(highlight.textType) | ||
| ); | ||
| } catch (IllegalArgumentException e) { | ||
| LOG.warn("Failed to save highlight", e); |
There was a problem hiding this comment.
Should we include in the warning the filename and the line number? I think it could help us save some time to investigate issues reported by users.
| ); | ||
| } | ||
| } catch (IllegalArgumentException e) { | ||
| LOG.warn("Failed to create symbol", e); |
There was a problem hiding this comment.
Same question.
yassin-kammoun-sonarsource
approved these changes
Mar 21, 2024
|
yassin-kammoun-sonarsource
assigned saberduck and unassigned yassin-kammoun-sonarsource
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4550