Add more analysis warnings #4455
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
...gin/sonar-javascript-plugin/src/main/java/org/sonar/plugins/javascript/JavaScriptPlugin.java
Outdated
Show resolved
Hide resolved
...r-javascript-plugin/src/main/java/org/sonar/plugins/javascript/bridge/AnalysisProcessor.java
Outdated
Show resolved
Hide resolved
...javascript-plugin/src/main/java/org/sonar/plugins/javascript/bridge/AnalysisWithProgram.java
Outdated
Show resolved
Hide resolved
...javascript-plugin/src/main/java/org/sonar/plugins/javascript/bridge/AnalysisWithProgram.java
Outdated
Show resolved
Hide resolved
...cript-plugin/src/main/java/org/sonar/plugins/javascript/bridge/AnalysisWithWatchProgram.java
Outdated
Show resolved
Hide resolved
…lugins/javascript/JavaScriptPlugin.java Co-authored-by: Ilia Kebets <104737176+ilia-kebets-sonarsource@users.noreply.github.com>
...onar-javascript-plugin/src/test/java/org/sonar/plugins/javascript/bridge/JsTsSensorTest.java
Outdated
Show resolved
Hide resolved
…lugins/javascript/bridge/AnalysisProcessor.java Co-authored-by: Ilia Kebets <104737176+ilia-kebets-sonarsource@users.noreply.github.com>
…lugins/javascript/bridge/AnalysisWithProgram.java Co-authored-by: Ilia Kebets <104737176+ilia-kebets-sonarsource@users.noreply.github.com>
…lugins/javascript/bridge/AnalysisWithWatchProgram.java Co-authored-by: Ilia Kebets <104737176+ilia-kebets-sonarsource@users.noreply.github.com>
| @@ -61,6 +61,7 @@ | |||
|
|
|||
| public class JavaScriptPlugin implements Plugin { | |||
|
|
|||
| public static final String TYPESCRIPT_VERSION = "5.3.2"; | |||
There was a problem hiding this comment.
could you add the test we discussed yesterday? the one that reads the package.json file
There was a problem hiding this comment.
I thought that the test in src/test/java/com/sonar/javascript/it/plugin/EslintCustomRulesTest.java was implicitly doing so, as the output that it checks comes from node. Do you still think it makes sense to do it?
There was a problem hiding this comment.
I guess it does. If we remove that test, it would be nice to make sure that this assertion is verified.
…lugins/javascript/bridge/AnalysisWithProgram.java Co-authored-by: Ilia Kebets <104737176+ilia-kebets-sonarsource@users.noreply.github.com>
…to analysis-warnings
|
100.0% Coverage on New Code
0.0% Duplication on New Code
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4438
Added warnings on program creation failure and a summary of parsing errors