Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create rule S6861 (eslint-plugin-import/no-mutable-exports): Mutable variables should not be exported #4441

Merged
merged 1 commit into from
Nov 28, 2023
Merged

Create rule S6861 (eslint-plugin-import/no-mutable-exports): Mutable variables should not be exported #4441

merged 1 commit into from
Nov 28, 2023

Conversation

yassin-kammoun-sonarsource
Copy link
Contributor

Fixes #4433

@sonarqube-next SonarQube-Next
Copy link

Quality Gate passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
100.0% 100.0% Coverage on New Code
0.0% 0.0% Duplication on New Code

See analysis details on SonarQube

ilia-kebets-sonarsource
ilia-kebets-sonarsource approved these changes Nov 28, 2023
View reviewed changes
Copy link
Contributor

@ilia-kebets-sonarsource ilia-kebets-sonarsource left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. That's quite a lot more issues than what I expected.

@ilia-kebets-sonarsource ilia-kebets-sonarsource changed the title Create rule S6861: Mutable variables should not be exported Create rule S6861 (eslint-plugin-import/no-mutable-exports): Mutable variables should not be exported Nov 28, 2023
@yassin-kammoun-sonarsource yassin-kammoun-sonarsource merged commit 7c4d58b into master Nov 28, 2023
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ilia-kebets-sonarsource ilia-kebets-sonarsource ilia-kebets-sonarsource approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Create rule S6861: Mutable variables should not be exported
2 participants
@yassin-kammoun-sonarsource @ilia-kebets-sonarsource