-
Notifications
You must be signed in to change notification settings - Fork 182
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add rule S6859 (eslint-plugin-import/no-absolute-path
): Imports should not use absolute paths
#4439
Merged
ilia-kebets-sonarsource
merged 2 commits into
master
from
issue-4432-S6859-absolute-path-import
Nov 28, 2023
Merged
Add rule S6859 (eslint-plugin-import/no-absolute-path
): Imports should not use absolute paths
#4439
ilia-kebets-sonarsource
merged 2 commits into
master
from
issue-4432-S6859-absolute-path-import
Nov 28, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ilia-kebets-sonarsource
force-pushed
the
issue-4432-S6859-absolute-path-import
branch
from
November 27, 2023 16:50
9fb0401
to
ba3cb5f
Compare
@yassin-kammoun-sonarsource Could you please run |
yassin-kammoun-sonarsource
approved these changes
Nov 28, 2023
ilia-kebets-sonarsource
force-pushed
the
issue-4432-S6859-absolute-path-import
branch
2 times, most recently
from
November 28, 2023 11:27
e462f10
to
3f31a3e
Compare
yassin-kammoun-sonarsource
requested changes
Nov 28, 2023
@@ -28,6 +28,7 @@ const quickFixMessages = new Map<string, string>([ | |||
['comma-dangle', 'Remove this trailing comma'], | |||
['eol-last', 'Add a new line at the end of file'], | |||
['jsx-no-useless-fragment', 'Remove redundant fragment'], | |||
['no-absolute-path', 'Do not import modules using an absolute path'], |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggested change
['no-absolute-path', 'Do not import modules using an absolute path'], | |
['no-absolute-path', 'Replace with a relative path'], |
…uld not use absolute paths
ilia-kebets-sonarsource
force-pushed
the
issue-4432-S6859-absolute-path-import
branch
from
November 28, 2023 13:05
3f31a3e
to
0d2d4c5
Compare
Quality Gate passedKudos, no new issues were introduced! 0 New issues |
yassin-kammoun-sonarsource
approved these changes
Nov 28, 2023
ilia-kebets-sonarsource
deleted the
issue-4432-S6859-absolute-path-import
branch
November 28, 2023 14:57
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4432