Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix regex-related rules: Skip issues with inconsistent locations #4337

Merged
merged 4 commits into from
Oct 31, 2023
Merged

Fix regex-related rules: Skip issues with inconsistent locations #4337

merged 4 commits into from
Oct 31, 2023

Conversation

vdiez
Copy link
Contributor

@vdiez vdiez commented Oct 31, 2023

Fixes #4258

@sonarqube-next SonarQube-Next
Copy link

Quality Gate passed Quality Gate passed

Kudos, no new issues are introduced in this PR!

0 New issues
0 Security Hotspots
100.0% 100.0% Coverage on New Code
0.0% 0.0% Duplication on New Code

See analysis details on SonarQube

@yassin-kammoun-sonarsource yassin-kammoun-sonarsource changed the title Hide invalid locations Fix regex-related rules: Skip issues with inconsistent locations Oct 31, 2023
yassin-kammoun-sonarsource
yassin-kammoun-sonarsource approved these changes Oct 31, 2023
View reviewed changes
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Did you check locally that the original issue no longer makes the analysis crash with this fix?

@yassin-kammoun-sonarsource
Copy link
Contributor

FYI, I renamed the PR title.

@vdiez
Copy link
Contributor Author

vdiez commented Oct 31, 2023

Yes, it's precisely the test I added here

@vdiez vdiez merged commit 709e764 into master Oct 31, 2023
17 checks passed
@vdiez vdiez deleted the fix-invalid-location branch October 31, 2023 15:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yassin-kammoun-sonarsource yassin-kammoun-sonarsource yassin-kammoun-sonarsource approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

getRegexpRange() returns incorrect results when regexp contains unescaped newline characters
2 participants
@vdiez @yassin-kammoun-sonarsource