Improve memory configuration message when running in Docker #4269
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an addition to #4255 to improve logging when running in a Docker container, where
os.totalMem
would report the memory of the whole host machine. We try to read the memory configuration from cgroup parameters exposed insys
.Additionally, I fixed the computation of size in MB by using binary Mega 1024*1024.
Unfortunately, there is no easy way to unit test.