Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up Git submodules and ruling tests #4224

Merged
merged 18 commits into from
Oct 3, 2023

Conversation

victor-diez-sonarsource
Copy link
Contributor

No description provided.

@victor-diez-sonarsource victor-diez-sonarsource changed the title Clean up Git submodules Clean up Git submodules and ruling tests Sep 29, 2023
@ilia-kebets-sonarsource
Copy link
Contributor

I'll give my review here as the diff is too large to work on github:

  1. I don't know if it's a local duplicate, but there's a its/ruling/src/test/expected/jsts/jsts folder holding a copy of the JS projects
  2. document why we do cleanRootNodeModules()
  3. put javascript-test-sources/ projects at root level like the others

* flat projects
* added doc
* remove child jsts folder
Copy link
Contributor

@ilia-kebets-sonarsource ilia-kebets-sonarsource left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.
As discussed, what is left to do for this task is:

  1. communicate instructions to the squad on how to update to this new folder layout
  2. write to REs to change the name of the sources repo
  3. apply this update in the code

@sonarqube-next
Copy link

sonarqube-next bot commented Oct 3, 2023

SonarQube Quality Gate

Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@victor-diez-sonarsource victor-diez-sonarsource merged commit fdf1762 into master Oct 3, 2023
16 checks passed
@victor-diez-sonarsource victor-diez-sonarsource deleted the clean-submodules branch October 3, 2023 12:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants