-
Notifications
You must be signed in to change notification settings - Fork 182
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add sanity check on adding a new rule property #4222
Conversation
4a328ec
to
f15515d
Compare
@@ -64,6 +67,23 @@ void rules_default_is_empty() | |||
} | |||
} | |||
|
|||
/* | |||
* This test raises awareness of the consequence of a rule adding or removing a rule property. | |||
* If a new rule property is added, we should inform the SonarCloud team about it on release. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
maybe link to some process on how to contact them?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are none. That should be email communication in my opinion.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
And I also mentioned this in our release procedures.
SonarQube Quality Gate |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
No description provided.