FP S1135: surrounding accented characters should be considered #2960
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
For the record, the regular expression was found here https://stackoverflow.com/a/26900132. |
vilchik-elena
requested changes
Feb 15, 2022
eslint-bridge/src/rules/todo-tag.ts
Outdated
| @@ -24,6 +24,7 @@ import { TSESTree } from '@typescript-eslint/experimental-utils'; | |||
|
|
|||
| const todoMessage = 'Complete the task associated to this "TODO" comment.'; | |||
| const todoPattern = 'todo'; | |||
| const letterPattern = /[A-Za-zÀ-ÖØ-öø-ÿ]/; | |||
There was a problem hiding this comment.
I found this one /[\p{Letter}]/u. Seems more reliable and matches ā not matched by your regex
There was a problem hiding this comment.
Thanks.
|
@yassin-kammoun-sonarsource could you add a code example to the fixed issue? |
|
SonarQube Quality Gate
|
vilchik-elena
approved these changes
Feb 15, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2957