Fix FP S4023 (no-empty-interface): Ignore when extending external i…

…nterfaces (#4326)

its/ruling/src/test/expected/jsts/TypeScript/typescript-S4023.json

@@ -1,29 +1,9 @@
 {
 "TypeScript:scripts/word2md.ts": [
 57,
-60,
-67,
-81,
-99,
-112
-],
-"TypeScript:src/compiler/types.ts": [
-3161
+99
 ],
 "TypeScript:src/harness/loggedIO.ts": [
 12
-],
-"TypeScript:src/server/protocol.ts": [
-1027,
-1101,
-1108,
-1133,
-1210,
-1678,
-1936,
-2223
-],
-"TypeScript:src/services/types.ts": [
-366
 ]
 }

its/ruling/src/test/expected/jsts/ag-grid/typescript-S4023.json

@@ -1,7 +1,4 @@
 {
-"ag-grid:src/ts/filter/filter.ts": [
-4
-],
 "ag-grid:src/ts/filter/floatingFilter.ts": [
 14
 ],
@@ -14,9 +11,6 @@
 "ag-grid:src/ts/interfaces/iEnterpriseCache.ts": [
 2
 ],
-"ag-grid:src/ts/interfaces/iExcelCreator.ts": [
-105
-],
 "ag-grid:src/ts/interfaces/iMenu.ts": [
 2
 ]

its/ruling/src/test/expected/jsts/console/typescript-S4023.json

@@ -44,9 +44,6 @@
 "console:src/mutations/UpdateRelationMutation.ts": [
 17
 ],
-"console:src/utils/classnames.ts": [
-10
-],
 "console:src/views/CLIAuthView/CLIAuthSuccessView.tsx": [
 5
 ],

sonar-plugin/javascript-checks/src/main/java/org/sonar/javascript/checks/NoEmptyInterfaceCheck.java

@@ -19,6 +19,7 @@
  */
 package org.sonar.javascript.checks;
 
+import java.util.List;
 import org.sonar.check.Rule;
 import org.sonar.plugins.javascript.api.EslintBasedCheck;
 import org.sonar.plugins.javascript.api.TypeScriptRule;
@@ -31,4 +32,14 @@ public class NoEmptyInterfaceCheck implements EslintBasedCheck {
   public String eslintKey() {
     return "no-empty-interface";
   }
+
+  @Override
+  public List<Object> configurations() {
+    return List.of(new Config());
+  }
+
+  private static class Config {
+
+    boolean allowSingleExtends = true;
+  }
 }

sonar-plugin/javascript-checks/src/test/java/org/sonar/javascript/checks/NoEmptyInterfaceCheckTest.java

@@ -0,0 +1,34 @@
+/*
+ * SonarQube JavaScript Plugin
+ * Copyright (C) 2011-2023 SonarSource SA
+ * mailto:info AT sonarsource DOT com
+ *
+ * This program is free software; you can redistribute it and/or
+ * modify it under the terms of the GNU Lesser General Public
+ * License as published by the Free Software Foundation; either
+ * version 3 of the License, or (at your option) any later version.
+ *
+ * This program is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the GNU
+ * Lesser General Public License for more details.
+ *
+ * You should have received a copy of the GNU Lesser General Public License
+ * along with this program; if not, write to the Free Software Foundation,
+ * Inc., 51 Franklin Street, Fifth Floor, Boston, MA  02110-1301, USA.
+ */
+package org.sonar.javascript.checks;
+
+import static org.assertj.core.api.Assertions.assertThat;
+
+import com.google.gson.Gson;
+import org.junit.jupiter.api.Test;
+
+class NoEmptyInterfaceCheckTest {
+
+  @Test
+  void configurations() {
+    String configAsString = new Gson().toJson(new NoEmptyInterfaceCheck().configurations());
+    assertThat(configAsString).isEqualTo("[{\"allowSingleExtends\":true}]");
+  }
+}