Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor reportPath to reportPaths as requested by #1219 #1869

Merged

Conversation

begarco
Copy link
Contributor

@begarco begarco commented May 22, 2020

Proposed changes

This pull request only change remaining reportPath to reportPaths in accordance with the case. This PR should be merge after #1868.

Issues closed by changes

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update

Checklist

  • Lint and unit tests pass locally with my changes
  • I have added tests that prove the feature works
  • I have added necessary documentation (if appropriate)

This change is Reviewable

@ghost
Copy link

ghost commented May 22, 2020

DeepCode's analysis on #e07ff8 found:

2 minor issues.

👉 View analysis in DeepCode’s Dashboard

☺️ If you want to provide feedback on our bot, here is how to contact us.

@guwirth
Copy link
Collaborator

guwirth commented May 22, 2020

@begarco please rebase to see differences

@guwirth
Copy link
Collaborator

guwirth commented May 22, 2020

@begarco

@begarco begarco force-pushed the feature-refactor-reportPath branch from 11240f7 to 9978e2b Compare May 22, 2020 17:45
@begarco
Copy link
Contributor Author

begarco commented May 22, 2020

@guwirth

  • Every properties in SonarSource's plugins are named *.reportPaths so it seems standard to rename cxx properties as well.
  • done, I added all reportPath properties

Copy link
Collaborator

@guwirth guwirth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@begarco thanks. Agree that the seems to use reportPaths now.

@guwirth guwirth merged commit c97a1f1 into SonarOpenCommunity:master May 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

Refactoring: Rename reportPath to reportsPaths
2 participants