remove vulnerabilities

[guwirth]

• and some more issues

---

This change is 

[ivangalkin]

Reviewed 66 of 66 files at r1.
Reviewable status: all files reviewed, 5 unresolved discussions (waiting on @guwirth and @Bertk)

---

cxx-checks/src/main/java/org/sonar/cxx/checks/regex/FileHeaderCheck.java, line 114 at r1 (raw file):

Files.readLines

off-topic: this check could be improved. If we want to check the presence of N expected header lines (where N == expectedLines.length) , we don't have to read the whole file. It's enough to (try to) read N first lines only.

---

cxx-sensors/src/main/java/org/sonar/cxx/sensors/utils/CxxUtils.java, line 62 at r1 (raw file):

  public static void transformFile(Source stylesheetFile, File input, File output) throws TransformerException {
    TransformerFactory factory = TransformerFactory.newInstance();
    factory.setFeature(XMLConstants.FEATURE_SECURE_PROCESSING, true);

I think this change is worth mentioning explicitly in the change log. It might introduce issues during migration from 1.2 to 1.2.1

---

cxx-sensors/src/main/java/org/sonar/cxx/sensors/visitors/CxxFileLinesVisitor.java, line 60 at r1 (raw file):

 private static final Set<Integer> LINES_OF_CODE = Sets.newHashSet();
  private static final Set<Integer> LINES_OF_COMMENTS = Sets.newHashSet();
  private static final Set<Integer> EXECUTABLE_LINES = Sets.newHashSet();

It's wrong to have this collections static. They have to be just normal member variables. Therefore the uppercase is not necessary here in the long term.

---

cxx-sensors/src/main/java/org/sonar/cxx/sensors/visitors/CxxFileLinesVisitor.java, line 187 at r1 (raw file):

  @Override
  public void visitFile(AstNode astNode) {

as you see, collections are resetted for each analyzed file. It would be wrong to aggregate any results in the visitors - calculation engine does it automatically by itself.

---

cxx-squid/src/main/java/org/sonar/cxx/CxxAstScanner.java, line 245 at r1 (raw file):

    int lenOfA = a.length();
    int lenOfB = b.length();
    int minIntersectionLen = min(lenOfB, lenOfA);

thx!

[guwirth]

@ivangalkin thx will add your review comments to another PR.