support xunit reports without testsuite

[guwirth]

• close xUnit sensor couldn't parse test report with 0 testsuite tag #1595

---

This change is 

[ivangalkin]

Reviewed 3 of 3 files at r1.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @guwirth and @Bertk)

---

cxx-sensors/src/main/java/org/sonar/cxx/sensors/tests/xunit/XunitReportParser.java, line 59 at r1 (raw file):

throw new EmptyReportException(...)

I believe, that the previous code tried to implement the standard protocol for all our report parsers: If the file is empty or invalid the parser has to throw EmptyReportException. The name and the purpose of this exception is ambiguous in my opinion. E.g. since the report is empty the fix could look as following...

try {
   final SMEvent event = testSuiteCursor.getNext();
   if (event == nullptr) {
      throw new EmptyReportException("Empty report");
   }
}

But on the other hand, IMHO there is no reason to throw an exception if the XML file is perfectly correct (like in the #1595). So I like your solution more.

[guwirth]

@ivangalkin think the difference is

• empty / corrupt XML => exception
• or iterating over testsuites (with special case no testsuite)