Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PC-lint Plus v1.3 and v1.3.5 new messages (rules) are missing from PC-lint (C++) repository of sonar-cxx plugin #2085

Closed
chswap opened this issue Mar 18, 2021 · 6 comments · Fixed by #2221
Assignees
Milestone

Comments

@chswap
Copy link

chswap commented Mar 18, 2021

Describe the bug
PC-lint Plus v1.3 and v1.3.5 new messages (rules) are missing from PC-lint (C++) repository of sonar-cxx plugin

Expected behavior
There are new messages added by Gimpel in new versions of PC-lint Plus v1.3 and v1.3.5. These messages are missing from PC-lint (C++) repository of sonar-cxx plugin. Due to this issue, sonar-cxx plugin is not able to filter issues of these new messages. New messages list is attached. These new messages should be included in repsoisory so that issues related to these rules are filtered by SonarQube.

Additional context
Refer Release notes of PC-lint Plus for more details on new messages.
PC-lint Plus 1.3 and 1.3.5 Rules.txt

@guwirth
Copy link
Collaborator

guwirth commented Mar 18, 2021

Hello @chswap,

thanks for your feedback.

We don’t have the tool, so maybe easiest would be you add them to https://github.com/SonarOpenCommunity/sonar-cxx/blob/master/cxx-sensors/src/main/resources/pclint.xml and create a PR.

Regards,

@chswap
Copy link
Author

chswap commented Mar 18, 2021

Hello Guntar,

Thanks for your quick feedback.
I will update the pclint resource file with all new messages and create a PR.

Regards,
Swapnil

@guwirth
Copy link
Collaborator

guwirth commented Mar 18, 2021

Hello @chswap,

thanks for your support, looking forward to your solution.
Please fix then also the unit test (number of rules):

Regards,

@guwirth
Copy link
Collaborator

guwirth commented Apr 12, 2021

Hello @chswap,

still interest to extend the rules? End of April we will create the final 2.0 version.

Regards

@chswap
Copy link
Author

chswap commented Jun 29, 2021

Hi @guwirth

We have started working on this issue and soon we will merge the code via PR. @Vishal-Gaikwad from my team will take this further.

Thanks,
Swapnil

Vishal-Gaikwad added a commit to Vishal-Gaikwad/sonar-cxx that referenced this issue Jun 29, 2021
Added new PC-Lint Plus rules to implement changes  SonarOpenCommunity#2085
Vishal-Gaikwad added a commit to Vishal-Gaikwad/sonar-cxx that referenced this issue Jun 29, 2021
Updated total rules count to implement change SonarOpenCommunity#2085
@guwirth
Copy link
Collaborator

guwirth commented Jun 29, 2021

@chswap thx

guwirth pushed a commit to guwirth/sonar-cxx that referenced this issue Jul 23, 2021
Added new PC-Lint Plus rules to implement changes  SonarOpenCommunity#2085
guwirth pushed a commit to guwirth/sonar-cxx that referenced this issue Jul 23, 2021
Updated total rules count to implement change SonarOpenCommunity#2085
@guwirth guwirth added this to the 2.0.5 milestone Jul 23, 2021
@guwirth guwirth self-assigned this Jul 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging a pull request may close this issue.

2 participants