upgrade to aspnet3 #307
Merged
upgrade to aspnet3 #307
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shaikatz
suggested changes
Sep 15, 2019
|
Done |
shaikatz
previously approved these changes
Sep 15, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While adding support for #248 in the chart, I find out that helm can generate the required TLS cert files for the conversation webhook - just not in PFX format. Look like in .NET core 3 we can finally import a pem file private key, so I just upgraded the CRD controller to .NET core 3 latest preview. The GA version should be available this month - and then we can upgrade the rest of the projects.
The code is based on this StackOver Flow answer - it's pretty magic to know which method to call based on the file 🤷♂